Open
Conversation
Contributor
Author
ThomasKroes
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
ScatterplotPlugin::init()we connect theDataset<Points>::changedsignal from_positionDatasettwice, to bothupdateData()andupdateHeadsUpDisplay()- this seems to result in a different call order on linux with gcc compared to Windows with MSVC, which ultimately yields a memory issue and causes a crash when loading data into the scatterplot. This PR bundles the calls to force consistent calling order.Also
_positionDataset's signal,Dataset<>::guiNameChangedis connected twice toupdateHeadsUpDisplay(), we only need to do this once.To prevent duplication I refactored
init()such that all the connections are grouped.