Conversation
ThomasKroes
reviewed
Jun 3, 2025
Contributor
ThomasKroes
left a comment
There was a problem hiding this comment.
I have a small suggestion:
{
"name" : "Scatterplot View",
"version" : {
"plugin": "1.0.0",
"core": ["1.3"]
},
"dependencies" : ["Points"],
}
To me bundling version-related values makes a bit more sense.
Contributor
Author
|
I moved the config handling to the core, nested the versions and added an optional plugin type field to the config file. The setup call |
ThomasKroes
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/ScatterplotPlugin.jsonto./PluginInfo.jsonScatterplotPlugin_p1.0.0_c1.4.0.dllon WindowslibScatterplotPlugin_p1.0.0_c1.4.0.dylibon MaclibScatterplotPlugin_p1.0.0_c1.4.0.soon LinuxDepends on ManiVaultStudio/core#910, ManiVaultStudio/core#911
find_package(ManiVault), but not each plugin had to repeat those lines.I'm not sure about thecoreversion entry in the plugin config file. We could keep it as a list, or name itcoreMinVersionmaybe. Either way, the library name will contain the core version that the plugin is build against.