fix: bar and area chart stacked toggle not working - #557
Open
Ju4n5e wants to merge 1 commit into
Open
Conversation
The UI stacked toggle sets `config.stacked` but BarChartTransformer and AreaChartTransformer only checked `config.mark?.stack`, which is never set by the config parser (vizConfigFromProps). This caused stacked bars/areas to always render as grouped. Also check `config.stacked` so the toggle takes effect. Fixes Make-md#556 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config.stacked, butBarChartTransformerandAreaChartTransformeronly checkedconfig.mark?.stack(which is never set by the config parser)|| config.stacked === trueto both transformers so the toggle takes effectFixes #556
Details
The config parser (
vizConfigFromProps) maps thestackedUI property toconfig.stacked(top-level). However, bothBarChartTransformer.transform()(line 140) andAreaChartTransformer.transform()(line 98) only checkconfig.mark?.stack, which is never populated.The legacy render path in
D3VisualizationEnginecorrectly checks the top-levelconfig.stacked, but the newerrenderWithTransformedDatapath (which takes priority whentransformedDataexists) relies on the transformers, which miss it.Test plan
🤖 Generated with Claude Code