fix(systeminformation): output right 'used node' version (from parent process)#4141
Merged
khassel merged 1 commit intoMagicMirrorOrg:developfrom May 6, 2026
Merged
Conversation
khassel
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that in the System Information output,
used nodeandinstalled nodewere always identical when starting via Electron. That usually shouldn't be the case. After digging into it, I found that since PR #4002,used nodein the subprocess effectively reported the system Node version, not the parent process (which runs in Electron) version.This PR fixes that by passing
used nodefrom the parent process and logging it correctly.Before:
VERSIONS: electron: 41.3.0; used node: 26.0.0; installed node: 26.0.0; ...After:
VERSIONS: electron: 41.3.0; used node: 24.15.0; installed node: 26.0.0; ...