Fixes the 100-call limit for creating zip files.#1
Open
karantza wants to merge 2 commits into
Open
Conversation
…ots, which can run out, we instead scan the array to find the first free slot, and reserve it in a threadsafe way. Can now handle 100 simultaneous zips, rather than 100 TOTAL zips.
…om git in node_modules directly
karantza
force-pushed
the
fix/handle-exhaustion
branch
from
fd3aef6 to
e39ccd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of a single incrementing counter to handle zip handle slots, which can run out, we instead scan the array to find the first free slot, and reserve it in a threadsafe way. Can now handle 100 simultaneous zips, rather than 100 TOTAL zips.
This was noticed in a project where a webserver endpoint was generating zips in memory; it would fail (looking like OOM) after 100 calls. It was just running out of handles. This fixes it, with a unit test to verify.
I added some locking around it to ensure that in a multithreaded environment we don't double-grab the same slot. The old code wasn't threadsafe anyway, so I'm not sure that it makes a huge difference, but it seemed prudent. There's more room here now for a race condition to cause a slot to be double-claimed.
(Also I just realized my formatter removed a bunch of whitespace; oops. Let me know if you'd like a cleaner version of the PR.)