Skip to content

Conversation

@fabricioalvarenga
Copy link
Contributor

Description

Images were added to various types of posts (latest news, rumors, highlights, etc.). However, I couldn't figure out how to place the image above the title for videos (they ended up next to the article title).

Type of Change

  • 🎉 feat: New feature
  • 🐛 fix: Bug fix
  • 📝 docs: Documentation update
  • 💄 style: Code style/formatting changes
  • ♻️ refactor: Code refactoring
  • perf: Performance improvement
  • test: Adding or updating tests
  • 🔧 chore: Maintenance tasks
  • 🏗️ build: Build system changes
  • 👷 ci: CI configuration changes

Related Issue

Screenshots/Videos

image

Testing

  • Tested on iPhone (specify model/iOS version):
  • Tested on iPad (specify model/iOS version):
  • All unit tests pass
  • No SwiftLint warnings/errors

Checklist

  • My code follows the project's code style
  • I have performed a self-review of my code
  • I have commented my code where necessary
  • I have updated the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My branch is up-to-date with the base branch

Additional Notes

One detail: it's still necessary to remove the line limit for titles in some cases to prevent them from being "cut off" and ending with "...".

@fabricioalvarenga fabricioalvarenga changed the title Add images to all posts feat: add images to all posts Feb 3, 2026
@fabricioalvarenga
Copy link
Contributor Author

@cassio-rossi tomei a liberdade de excluir os arquivos SimpleCardView.swift e LeadingCardView.swift. Como os códigos desses dois arquivos eram muito parecidos, criei o arquivo CardView.swift englobando os dois arquivos. Caso prefira manter um arquivo separado para cada tipo de carregamento de imagem (à esquerda, no topo, etc), basta recusar o pull request.

@cassio-rossi
Copy link
Collaborator

@fabricioalvarenga obrigado. nós ainda estamos trabalhando no layout desses cartões. Vou deixar a PR aberta, mas iremos ter layout diferente por categoria. Semana que vem retomarei os trabalhos nesse assunto. Aguarde novidades. Obrigado de qq maneira.

@cassio-rossi
Copy link
Collaborator

E também tenho que atualizar a branch develop, que é a branch correta para usarmos nesse momento. Te aviso quando tiver o ambiente pronto novamente.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants