feat: add use_representation_model option to hierarchical_topics() for parent node labeling#2513
Open
pidefrem wants to merge 1 commit into
Open
feat: add use_representation_model option to hierarchical_topics() for parent node labeling#2513pidefrem wants to merge 1 commit into
use_representation_model option to hierarchical_topics() for parent node labeling#2513pidefrem wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
feat: add
use_representation_modeloption tohierarchical_topics()for parent node labelinghierarchical_topics()builds parent topic names by concatenating the top 5 c-TF-IDF keywords (e.g.,"wear_safety_PPE_worker_work"), while leaf topics get rich labels from the representation model (e.g.,"PPE Non-Compliance Incidents"via an LLM). This creates a jarring inconsistency invisualize_hierarchy().Root cause:
_extract_words_per_topicis called withcalculate_aspects=Falsefor parent nodes.Changes:
Add
use_representation_model: bool = Falseparameter tohierarchical_topics(). When enabled, a post-processing step runs the full representation pipeline on all parent topics in a single batch call — not inline during the merge loop (which would make N-1 separate LLM calls).Default is
False— existing behavior unchanged. The batch approach keeps LLM cost bounded.Fixes #2503
Note: Cleaner if #2497 (shared helpers refactoring) lands first, but works standalone.
Before submitting