feat: add top-down (divisive) strategy for hierarchical_topics()#2512
Open
pidefrem wants to merge 1 commit into
Open
feat: add top-down (divisive) strategy for hierarchical_topics()#2512pidefrem wants to merge 1 commit into
hierarchical_topics()#2512pidefrem wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
feat: add top-down (divisive) strategy for
hierarchical_topics()hierarchical_topics()builds hierarchies exclusively bottom-up using scipy's agglomerative linkage. While this works for small topic counts, merge quality degrades at higher levels and it has a known bug when 3+ topics have identical c-TF-IDF distances (#1907).Changes:
Add a
strategyparameter tohierarchical_topics():The divisive path recursively splits topics using c-TF-IDF weighted NMF decomposition, building a tree where each parent-child relationship reflects a meaningful topic subdivision. Each split is locally optimal, avoiding the degradation of late merges in agglomerative linkage.
Default is
"agglomerative"— existing behavior unchanged.Fixes #2508
Coordination note: this adds a new
strategyoption rather than changing the default, so existing hierarchies are untouched. It introduces a top-down NMF code path, which is a meaningful addition to maintain — if you'd like to discuss scope (e.g. land it as experimental first) before reviewing, I'm happy to. It also pairs naturally with the parent-node labeling in #2503.Before submitting