Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #252 +/- ##
===========================================
+ Coverage 92.35% 92.39% +0.04%
===========================================
Files 192 194 +2
Lines 4693 4761 +68
Branches 351 353 +2
===========================================
+ Hits 4334 4399 +65
- Misses 272 275 +3
Partials 87 87 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dolfinus
reviewed
Aug 11, 2025
| COALESCE(translate(json_extract_path_text(target_params, 'directory_path'), './', ' '), '') | ||
| to_tsvector('russian', coalesce(name, '')) | ||
|
|
||
| || to_tsvector('simple', coalesce(name, '')) |
Member
There was a problem hiding this comment.
Let's add translate(name, punctiation, spaces) to all vectors, in case if someone uses hostname in connection/transfer name
dolfinus
reviewed
Aug 11, 2025
dolfinus
reviewed
Aug 11, 2025
| "search_vector", | ||
| postgresql.TSVECTOR(), | ||
| sa.Computed( | ||
| "\n to_tsvector('russian', coalesce(name, ''))\n || to_tsvector('simple', coalesce(name, '')) \n || to_tsvector('simple', coalesce(data->>'host', ''))\n || to_tsvector(\n 'simple',\n translate(\n coalesce(data->>'host', ''),\n './-_:\\', ' '\n )\n )\n ", |
Member
There was a problem hiding this comment.
Let's use here the same formatting as in models, as \n is hard to read
dolfinus
reviewed
Aug 11, 2025
| ), | ||
| ) | ||
| op.create_index("idx_transfer_search_vector", "transfer", ["search_vector"], unique=False, postgresql_using="gin") | ||
| op.add_column( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rstfile added describing change(see CONTRIBUTING.rst for details.)