Remove session disconnect after listing servers due to it causing a p…

[mfranca0009]

…roblem with subsequent logins with the same credentials after quitting the game.

Resolves issue #628, which seems to be caused by PR #430.

Summary by CodeRabbit

Bug Fixes

• Fixed an issue where the login session would disconnect immediately after viewing available servers, preventing users from completing the login process to select a server.

[coderabbitai]

📝 Walkthrough

Walkthrough

Removed a session.Disconnect() call in the LoginHandler's ServerList branch, allowing the session to remain active after listing servers instead of terminating it immediately. This enables continued processing of subsequent login operations.

Changes

Cohort / File(s)	Summary
Login Handler Session Management Maple2.Server.Login/PacketHandlers/LoginHandler.cs	Removed session.Disconnect() call from the ServerList branch to maintain session continuity for downstream handling instead of prematurely closing the connection.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A session once severed too soon,
Now flows gently onward—no need to swoon!
The disconnect vanished, the path stays alive,
And packets keep dancing, forever they thrive! 🌟

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: removing a session disconnect after listing servers, with a reference to the problem it causes (truncated but contextually clear from PR objectives).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

No actionable comments were generated in the recent review. 🎉

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[AngeloTadeucci]

I decided to rework session disconnect, should be much better with #630 ! thanks for issue and PR