Consolidating multiple definitions of vertical_interp into init_atm_vinterp#1429
Merged
mgduda merged 1 commit intoMPAS-Dev:developfrom Mar 25, 2026
Merged
Conversation
…interp This commit consolidates the multiple definitions of function vertical_interp, found in modules mpas_init_atm_cases and init_atm_vinterp in the init_atmosphere core and introduces one uniform definition in the init_atm_vinterp module
mgduda
approved these changes
Mar 25, 2026
Contributor
|
@abishekg7 "+16 -99" lines in the diff. It's always nice when we can remove more lines of code than we add! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit consolidates the multiple definitions of function
vertical_interp, found in modulesmpas_init_atm_casesandinit_atm_vinterpin the init_atmosphere core and introduces one uniform definition in theinit_atm_vinterpmodule.Pre-requisite for #1413