Create a core interface method to facilitate computed dimensions#1426
Open
islas wants to merge 1 commit intoMPAS-Dev:developfrom
Open
Create a core interface method to facilitate computed dimensions#1426islas wants to merge 1 commit intoMPAS-Dev:developfrom
islas wants to merge 1 commit intoMPAS-Dev:developfrom
Conversation
Currently there is no way of defining a dimension that is derived from preexisting values already present in input data. Various calls in the registry generated code require that state variables that would need a runtime-defined dimension exist prior to their usage and thus prior to the end of the bootstrapping sequence. As such, it is not feasible to have a core-only implementation of injecting a runtime computed dimension at the appropriate time of setup. This adds a methodology for cores to provide core-specific computed dimensions implementations by adding: 1. an interface subroutine to the core type 2. a computed dimensions interface types and module 3. invocation of new optional core interface function in bootstrapping The computed dimensions interface types and modules are based off of the same pattern used for decomposed dimensions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is no way of defining a dimension that is derived from preexisting values already present in input data. Various calls in the registry generated code require that state variables that would need a runtime-defined dimension exist prior to their usage and thus prior to the end of the bootstrapping sequence.
As such, it is not feasible to have a core-only implementation of injecting a runtime computed dimension at the appropriate time of setup.
This adds a methodology for cores to provide core-specific computed dimensions implementations by adding:
The computed dimensions interface types and modules are based off of the same pattern used for decomposed dimensions.