Skip to content

mods needed for wave- climatology (frequency)#1152

Merged
xylar merged 1 commit into
MPAS-Dev:developfrom
erinethomas:wave_mods
Jun 29, 2026
Merged

mods needed for wave- climatology (frequency)#1152
xylar merged 1 commit into
MPAS-Dev:developfrom
erinethomas:wave_mods

Conversation

@erinethomas

Copy link
Copy Markdown
Contributor

This is a bug fix for the task "climatologyMapWaves".
This fixes the following error with the wave-frequencies:
nco_put_vara() ERROR: Range of input data array values (possibly including _FillValue) is -88125.6 <= peakWavePeriod <= inf

@erinethomas erinethomas requested a review from sbrus89 June 29, 2026 15:50

@sbrus89 sbrus89 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by inspection. This looks like a good approach to me. I've used a similar fix in the past to get around this error. Thanks @erinethomas for submitting a PR to take care of it!

@xylar xylar self-assigned this Jun 29, 2026
@xylar xylar merged commit 97e1c1d into MPAS-Dev:develop Jun 29, 2026
10 checks passed
@xylar

xylar commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

@erinethomas and @sbrus89, do you need an MPAS-Analysis release as well?

@erinethomas

erinethomas commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

I would say, yes, at some point, but I'm running this in my own MPAS-Analysis environment (and I'm sure it's only me who needs this haha), so it is not critical/there is no rush or time restraint...

@xylar

xylar commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Okay, let me know when it's important. We typically only do releases twice a year for Unified unless there's another reason. That would mean the next release would be in November if I remember right.

@erinethomas

Copy link
Copy Markdown
Contributor Author

I would say November is perfect since I can use my own environment when I need this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants