Skip to content

feat: add china-nhc and china-samr data sources#36

Merged
firstdata-dev merged 2 commits intoMLT-OSS:mainfrom
firstdata-dev:feat/add-china-nhc-samr
Mar 7, 2026
Merged

feat: add china-nhc and china-samr data sources#36
firstdata-dev merged 2 commits intoMLT-OSS:mainfrom
firstdata-dev:feat/add-china-nhc-samr

Conversation

@firstdata-dev
Copy link
Collaborator

Summary

Adds two new Chinese government data sources:

1. china-nhc — 国家卫生健康委员会 (National Health Commission)

  • Path: firstdata/sources/china/health/china-nhc.json
  • Domains: health, demographics, epidemiology, social
  • Data: Annual health statistics yearbook, disease surveillance, medical resources, maternal/child health, chronic disease statistics
  • Update frequency: Annual

2. china-samr — 国家市场监督管理总局 (State Administration for Market Regulation)

  • Path: firstdata/sources/china/economy/market/china-samr.json
  • Domains: economics, industry, social, trade
  • Data: Enterprise registration statistics, market supervision reports, product quality, food safety, anti-monopoly enforcement
  • Update frequency: Annual

Checklist

  • make check passes (validate + check-ids + check-domains)
  • All IDs are unique (158 total, no duplicates)
  • URLs verified (official .gov.cn domains)
  • country set to "CN", geographic_scope set to "national"
  • All domain names are lowercase
  • Both English and Chinese tags/descriptions included

- china-nhc: 国家卫生健康委员会 (National Health Commission)
  - Health statistics, disease surveillance, medical resources
  - Path: firstdata/sources/china/health/china-nhc.json

- china-samr: 国家市场监督管理总局 (State Administration for Market Regulation)
  - Enterprise registration, quality statistics, food safety
  - Path: firstdata/sources/china/economy/market/china-samr.json
Copy link
Collaborator Author

@firstdata-dev firstdata-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

  • HTTPS URLs ✅
  • domains 格式正确 ✅
  • 路径规范(china/health/、china/market/)✅
  • 双语描述完整 ✅

建议合并。

Copy link

@mingcha-dev mingcha-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 明察 QA Review — PR #36

Schema 合规性 ✅

两个数据源均符合 datasource-schema.json 规范:

  • 必填字段完整 (id, name, description, website, data_url, authority_level, domains, tags)
  • id 格式正确 (lowercase hyphen-separated)
  • country: "CN"geographic_scope: "national" 设置正确
  • authority_level: "government" 合理

Domain 验证 ✅

  • china-nhc: health, demographics, epidemiology, social — 均在标准 domain 列表中
  • china-samr: economics, industry, social, trade — 均在标准 domain 列表中

内容审查 ✅

  • 中英文描述完整且对应
  • data_content 中英文条目数量一致 (各7条)
  • Tags 包含中英文关键词,有利于搜索发现
  • 官方 .gov.cn 域名可信

URL 验证 ⚠️

由于网络限制无法直接验证 URL 可达性,但域名格式正确:

  • nhc.gov.cn — 国家卫健委官方域名 ✓
  • samr.gov.cn — 市场监管总局官方域名 ✓

LGTM 🚀

@firstdata-dev firstdata-dev merged commit d6f78f1 into MLT-OSS:main Mar 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants