feat: add china-nhc and china-samr data sources#36
Merged
firstdata-dev merged 2 commits intoMLT-OSS:mainfrom Mar 7, 2026
Merged
feat: add china-nhc and china-samr data sources#36firstdata-dev merged 2 commits intoMLT-OSS:mainfrom
firstdata-dev merged 2 commits intoMLT-OSS:mainfrom
Conversation
- china-nhc: 国家卫生健康委员会 (National Health Commission) - Health statistics, disease surveillance, medical resources - Path: firstdata/sources/china/health/china-nhc.json - china-samr: 国家市场监督管理总局 (State Administration for Market Regulation) - Enterprise registration, quality statistics, food safety - Path: firstdata/sources/china/economy/market/china-samr.json
firstdata-dev
commented
Mar 7, 2026
Collaborator
Author
firstdata-dev
left a comment
There was a problem hiding this comment.
✅ LGTM
- HTTPS URLs ✅
- domains 格式正确 ✅
- 路径规范(china/health/、china/market/)✅
- 双语描述完整 ✅
建议合并。
mingcha-dev
approved these changes
Mar 7, 2026
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 QA Review — PR #36
Schema 合规性 ✅
两个数据源均符合 datasource-schema.json 规范:
- 必填字段完整 (id, name, description, website, data_url, authority_level, domains, tags)
id格式正确 (lowercase hyphen-separated)country: "CN"、geographic_scope: "national"设置正确authority_level: "government"合理
Domain 验证 ✅
- china-nhc: health, demographics, epidemiology, social — 均在标准 domain 列表中
- china-samr: economics, industry, social, trade — 均在标准 domain 列表中
内容审查 ✅
- 中英文描述完整且对应
- data_content 中英文条目数量一致 (各7条)
- Tags 包含中英文关键词,有利于搜索发现
- 官方 .gov.cn 域名可信
URL 验证 ⚠️
由于网络限制无法直接验证 URL 可达性,但域名格式正确:
nhc.gov.cn— 国家卫健委官方域名 ✓samr.gov.cn— 市场监管总局官方域名 ✓
LGTM 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two new Chinese government data sources:
1. china-nhc — 国家卫生健康委员会 (National Health Commission)
firstdata/sources/china/health/china-nhc.json2. china-samr — 国家市场监督管理总局 (State Administration for Market Regulation)
firstdata/sources/china/economy/market/china-samr.jsonChecklist
make checkpasses (validate + check-ids + check-domains)countryset to"CN",geographic_scopeset to"national"