fix(ids): rename china-cinic→china-cnnic & china-cinic-net→china-cinic (#233)#234
Merged
mingcha-dev merged 1 commit intoMay 13, 2026
Conversation
MLT-OSS#233) - firstdata/sources/china/technology/internet/cnnic.json -> china-cnnic.json, id: china-cinic -> china-cnnic (file already named cnnic.json on disk; was misnamed by id field only) - firstdata/sources/china/economy/macro/china-cinic-net.json -> china-cinic.json, id: china-cinic-net -> china-cinic (drop defensive -net suffix now that previous collision is resolved) - update tag 'china-cinic-net' -> 'china-cinic' inside the renamed file Closes MLT-OSS#233
mingcha-dev
approved these changes
May 13, 2026
Collaborator
mingcha-dev
left a comment
mingcha-dev
left a comment
There was a problem hiding this comment.
明察 QA Review — PR #234 APPROVED ✅（fix Issue #233）
ID 错位修复干净，rename + 内部引用同步全部正确。
Checklist
- ✅ CI 三项全绿
- ✅ Pre-PR 保密 lint rc=0
- ✅
--tags-lintrc=0 - ✅ 文件 rename 正确（git 识别
similarity 99%，无内容丢失） - ✅ 文件内
id字段 + tags 同步更新（diff+2/-2++1/-1，最小变更）
Rename 对照表
| 操作 | 旧 | 新 |
|---|---|---|
| Rename file | china/technology/internet/cnnic.json |
china/technology/internet/china-cnnic.json |
| Rename file | china/economy/macro/china-cinic-net.json |
china/economy/macro/china-cinic.json |
| ID 修正 | china-cinic（指 CNNIC） |
china-cnnic |
| ID 修正 | china-cinic-net（指 CINIC） |
china-cinic |
| Tag 同步 | china-cinic-net |
china-cinic（CINIC 文件内自引用） |
修复后状态校验（已实测）
| ID | 实际机构 | 文件路径 | website |
|---|---|---|---|
| china-cnnic | 中国互联网络信息中心 | china/technology/internet/china-cnnic.json |
cnnic.cn |
| china-cinic | 中国产业经济信息网 | china/economy/macro/china-cinic.json |
cinic.org.cn |
| （不复存在） | — | — |
Indexes 残留（非阻塞）
firstdata/indexes/{all-sources,by-domain,by-region,by-authority}.json中仍有 12 处china-cinic-net引用- 这些是 auto-generated（每次 PR merge 后由
chore(indexes): auto-update indexesjob 重建） - Merge 后会自动同步，无需手动处理
老 ID china-cinic 语义切换说明
china-cinic 仍存在但指向不同机构：
- 修前：
china-cinic= 互联网络信息中心 CNNIC - 修后：
china-cinic= 产业经济信息网 CINIC（真身回归）
下游若硬编码引用 china-cinic 期望拿到 CNNIC 数据 → 会拿到 CINIC（语义破坏性变更）。
评估：
- FirstData MCP 内部：search 按 tags / domains / 缩写匹配，老 ID 不进入硬编码
- 外部使用：rename 当天即应同步更新（无 deprecation period）
- 老板 15:01 指令"直接修复"已表态接受这种切割
流程
- Author-side：墨子
--tags-lintrc=0（第 5 次连续零违规 ✓） - Reviewer-side：本 review 走 3 步硬 gate
关联
- Closes #233（merge 后我去关闭 issue）
Merge 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
按 老板 在 #github 5/13 15:01 GMT+8 指令，直接修复 Issue #233 ID 错位问题。
变更
firstdata/sources/china/technology/internet/cnnic.json→china-cnnic.jsonid:china-cinic→china-cnnic（机构是中国互联网络信息中心 CNNIC，原 ID 错位）firstdata/sources/china/economy/macro/china-cinic-net.json→china-cinic.jsonid:china-cinic-net→china-cinic（CNNIC 让出名称后，真正的 CINIC = 中国产业经济信息网回归正名，去掉 PR feat: add 5 Chinese authoritative data sources (PM batch 2026-05-13) #232 的防御性-net后缀）"china-cinic-net"→"china-cinic"一致性
china-cnnicchina-cinicID 与官方缩写、域名一致。
检查
bash scripts/pre-pr-check.shrc=0（保密 +--tags-lint）关联
Closes #233