Conversation
- also added a note to the matomo injection script reminding devs that the error handling was added by us.
There was a problem hiding this comment.
Given that this builds on the former pattern, architecturally seems like a easy to follow, consistent update.
Left one comment for a code comment that may not be needed.
Bigger picture question: this appears to be a forked repository. Is it possible there is a desire to occassionally sync with the upstream repository? I'll be honest in saying this is not something I've done very often. If so, are there any concerns that these changes may conflict with a sync?
That question was actually inspired by a suggestion. I'm not sure if this is happening outside of this repository, but it might be helpful to document somewhere a) the kind of changes that are made to the forked base, and b) the specific changes. And/or, even just a single README.md that outlines our approach to making adjustments.
If this is all super normal Primo custom module stuff, please feel free to disregard. I was putting on my hat of knowing nothing (a hat I wear well and often), and realized it might not be obvious where our customizations like this start and the forked, "base" code ends.
All that said, in the scope of this change, looks good!
|
|
||
| export function injectLibchat() { | ||
| try { | ||
| var libchatHash = "1e8f3119e6cff530e0d23e2cb1f2b2a7"; // hash string goes inside quotation marks |
There was a problem hiding this comment.
Thinking maybe you don't need the comment, "// hash string goes inside quotation marks"? That feels implied by virtue of being a string variable.
|
@ghukill - We may want to merge changes from the forked repo. The |
Why these changes are being introduced
We want to add our libchat widget to Primo NDE
How this addresses that need
Injects the libanswers script for libchat during bootstrapping.
For consistency I'm using the same injection-during-bootstrapping approach we used for #19 although in this case, adding the libchat JS script to
src/assets/js/custom.jsseemed to work just as well as adding it during bootstrapping.Side effects of this change
none