Skip to content

Properly rotate GT rooms #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nathanhhughes merged 3 commits into from
Jun 12, 2026
Merged

Properly rotate GT rooms #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3dbf738
Properly rotate GT rooms
GoldenZephyr Apr 11, 2026
893f2c0
Set gt room frame id from config
GoldenZephyr Apr 11, 2026
e45f1ea
drop header
nathanhhughes Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion hydra_ros/include/hydra_ros/backend/gt_room_publisher.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ namespace hydra {
class GtRoomPublisher : public UpdateRoomsFunctor::Sink {
public:
struct Config {
std::string ns = "~gt_rooms";
std::string ns = "~/gt_rooms";
std::string room_frame_id = "map";
visualizer::DiscreteColormap::Config colormap;
} const config;

Expand Down
11 changes: 8 additions & 3 deletions hydra_ros/src/backend/gt_room_publisher.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ void declare_config(GtRoomPublisher::Config& config) {
using namespace config;
name("GtRoomPublisher::Config");
field(config.ns, "ns");
field(config.room_frame_id, "room_frame_id");
field(config.colormap, "colormap");
}

Expand All @@ -35,7 +36,6 @@ GtRoomPublisher::GtRoomPublisher(const Config& config)
std::string GtRoomPublisher::printInfo() const { return config::toString(config); }

void GtRoomPublisher::call(uint64_t, const RoomFinder& rf) const {
LOG(WARNING) << "GT Room sink called";
MarkerArray ma;
auto& m = ma.markers.emplace_back();
m.action = m.DELETEALL;
Expand All @@ -47,12 +47,17 @@ void GtRoomPublisher::call(uint64_t, const RoomFinder& rf) const {
for (auto room : rf.room_extents.room_bounding_boxes) {
for (auto box : room) {
auto& m = ma.markers.emplace_back();
m.header.frame_id = "map";
m.header.frame_id = config.room_frame_id;
m.ns = "gt_rooms";
m.id = idx++;
m.action = m.ADD;
m.type = m.CUBE;
m.pose.orientation.w = 1;

Eigen::Quaternionf q(box.world_R_center);
m.pose.orientation.x = q.x();
m.pose.orientation.y = q.y();
m.pose.orientation.z = q.z();
m.pose.orientation.w = q.w();
m.pose.position.x = box.world_P_center.x();
m.pose.position.y = box.world_P_center.y();
m.pose.position.z = box.world_P_center.z();
Expand Down
Loading