-
Notifications
You must be signed in to change notification settings - Fork 137
fix: correct MTHINC normals on non-uniform grids #1401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sbryngelson
wants to merge
41
commits into
MFlowCode:master
Choose a base branch
from
sbryngelson:MTHINC
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
5a8ca06
MTHINC interface compression method
sbryngelson b7f85c6
fix: remove stale THINC comment from m_muscl.fpp
sbryngelson 4c67385
fix: add GPU_DECLARE/GPU_UPDATE for int_comp, ic_eps, ic_beta
sbryngelson 102c3f1
fix MPI decomposition
wilfonba 80cc822
fix openmp build and add nvtx ranges
wilfonba ec3d918
fix weno/muscl_order = 1 with int_comp > 0 test suite error
wilfonba d8731d7
Merge branch 'master' into MTHINC
sbryngelson 6ef3991
review comments. Passes with OpenMP and OpenACC on NVHPC 25.11
wilfonba e50b2cc
Merge remote-tracking branch 'upstream/master' into MTHINC
wilfonba c913cc8
fixes for CCE
wilfonba ff02cc6
Merge branch 'master' into MTHINC
sbryngelson f3caca5
Merge branch 'master' into MTHINC
sbryngelson a4e0967
restor RDMA MPI golden files
wilfonba f515368
Merge branch 'MTHINC' of github.com:wilfonba/MFC-Wilfong into MTHINC
wilfonba 38a4bf4
styleistic changes
wilfonba 8310981
Merge remote-tracking branch 'upstream/master' into MTHINC
wilfonba 9c875b1
precheck
wilfonba a4bed32
add claude review suggestions
wilfonba c045e06
Merge remote-tracking branch 'upstream/master' into MTHINC
wilfonba 5f1a1e5
fix test suite for num_fluids==2 requirement with int_comp enabled
wilfonba 2c18593
fix interface compression tests by using sharp IC
wilfonba 0ad7445
add cases.py changes for int_comp tests IC
wilfonba e2c090e
Merge remote-tracking branch 'upstream/master' into MTHINC
wilfonba b06fdfa
restore RDMA test files
wilfonba 6d10d7b
merge
wilfonba 8bb2f25
add normal snapping for near grid aligned normals in MTHINC
wilfonba 4e306df
avoid dividing by zero in MTHINC
wilfonba 41950bc
Merge master into MTHINC: resolve conflicts
sbryngelson c183e43
fix: use compact declaration style in m_global_parameters.fpp to pass…
sbryngelson b4e01f8
fix: clear weno_eps/wenoz_q/teno_CT in alter_int_comp MUSCL push to p…
sbryngelson 631ca82
format: collapse multi-line ValueError in registry.py to pass formatter
sbryngelson 78062e3
test: regenerate 5126B21F golden file with gfortran CPU (matches CI)
sbryngelson 5d4d53d
fix: stable log_cosh difference and prohibit int_comp with viscous/su…
sbryngelson b1ae94d
fix: remove int_comp from rayleigh_taylor_muscl example (incompatible…
sbryngelson f31ce15
fix: use full reconstruction with int_comp to enable THINC with visco…
sbryngelson 3e3661c
test: regenerate 35635326 golden after enabling THINC with viscous re…
sbryngelson 8991b27
fix: extend int_comp full reconstruction to surface_tension path
sbryngelson 5b52d83
fix: correct MTHINC normals on non-uniform grids by weighting by cell…
sbryngelson ae74a6a
test: add MTHINC non-uniform grid golden test (circular bubble + stre…
sbryngelson cbabce3
fix: copy Gauss-quadrature constants to device, remove dead f_log_cosh
sbryngelson 3ebb1e3
fix: add use m_nvtx, clamp atanh in f_log_cosh_diff, add Fortran chec…
sbryngelson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
int_compcan consume an uninitialized MUSCL workspace in first-order mode.When
muscl_order == 1,s_initialize_muscl()is skipped above, sov_rs_ws_*_musclhas not been populated before this block passes it tos_thinc_compression(). That makesint_comp > 0+ first-order MUSCL undefined unless the combination is prohibited elsewhere. Either initialize the directional workspace for compressed runs too, or explicitly rejectmuscl_order == 1whenint_comp > 0.Possible fix