fix: correct single-precision CI testing

[sbryngelson]

Closes #759

Summary

• Add \$PRECISION to the Test step in `.github/workflows/test.yml` so single-precision binaries are actually tested with `--single` tolerances (root bug: `$PRECISION` was only in the Build step env, so the Test step ran double-precision test selection/tolerance against single-precision output)
• Change single-precision CI job from `mpi: no-mpi` to `mpi: mpi` so `--test-all` is passed and a broader test set is exercised

Test plan

• CI single-precision job builds with `--mpi --single`
• CI single-precision job runs tests with `--single` flag (1e-1 tolerances)
• No regressions in regular (double-precision) CI jobs

[coderabbitai]

Warning

Rate limit exceeded

@sbryngelson has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 59 minutes and 41 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e64f732f-bbe4-4b10-b997-1d0a7528f27a

📥 Commits

Reviewing files that changed from the base of the PR and between d513442 and 84ffb7a.

📒 Files selected for processing (1)

• .github/workflows/test.yml

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[qodo-code-review]

ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one.

[github-actions]

Claude Code Review

Head SHA: 84ffb7a

Files changed:

• 1
• .github/workflows/test.yml

Findings

Implicit --test-all side effect from mpi: no-mpi → mpi: mpi

The matrix entry changed at line 175 (mpi: no-mpi → mpi: mpi) silently activates --test-all for the single-precision run via the existing conditional:

TEST_ALL: ${{ matrix.mpi == 'mpi' && '--test-all' || '' }}

Before this PR, the single-precision entry had mpi: no-mpi, so TEST_ALL evaluated to '' and the test command ran only the default subset. After this change, TEST_ALL becomes '--test-all', so the effective test command becomes:

/bin/bash mfc.sh test -v --max-attempts 3 -j $(nproc) $ONLY_CHANGES --test-all --single

This is a substantially larger test scope than before. If the intent was only to add --single precision flag coverage with MPI, verify that running the full --test-all suite in this job is also desired — if not, the TEST_ALL condition should be updated to decouple MPI presence from full-suite execution.

[sbryngelson]

Automated Code Review

Summary: 0 critical issues, 0 issues.

Retraction

--only-changes and --test-all are now both active simultaneously on PRs for the single-precision job — this was a false positive.

The two flags are orthogonal: --only-changes controls which tests are run (tests affected by changed files), while --test-all controls which stages are run per test (pre_process + simulation + post_process vs. pre_process only). They compose without conflict. All other mpi: mpi jobs already get both flags on PRs, so this job's behavior is consistent with the rest of the matrix. No issue here.

Suggestions

• The primary fix (missing PRECISION in the Test step env: block) is correct. GitHub Actions step-level env: blocks are scoped to that step only — $PRECISION in the Test step was silently expanding to empty string, running single-precision outputs against double-precision tolerances.
• The mpi: no-mpi → mpi: mpi change is not strictly required to fix the tolerance bug. Splitting into two commits (tolerance fix; MPI/coverage expansion) would aid bisection if the broader test suite reveals failures.
• PRECISION expression is now duplicated identically in Build and Test step env: blocks — not a bug, but a comment noting why the duplication exists would help future maintainers.

Strengths

The root cause diagnosis is correct. The fix is minimal and correct. format('--{0}', matrix.precision) handles empty string and single exactly right. No secrets involved.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.75%. Comparing base (d513442) to head (84ffb7a).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1400   +/-   ##
=======================================
  Coverage   64.75%   64.75%           
=======================================
  Files          71       71           
  Lines       18721    18721           
  Branches     1551     1551           
=======================================
  Hits        12123    12123           
  Misses       5640     5640           
  Partials      958      958           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.