Skip to content

test reduced mass_fraction_limit - #1044

Open
Debraheem wants to merge 2 commits into
mainfrom
EbF/skye_mass_fractions_limit
Open

test reduced mass_fraction_limit#1044
Debraheem wants to merge 2 commits into
mainfrom
EbF/skye_mass_fractions_limit

Conversation

@Debraheem

Copy link
Copy Markdown
Member

No description provided.

@Debraheem
Debraheem requested a review from evbauer August 13, 2026 20:34
@Debraheem Debraheem added the eos Equation of state module label Aug 13, 2026
@Debraheem
Debraheem requested a review from fxt44 as a code owner August 13, 2026 20:34
@evbauer

evbauer commented Aug 13, 2026

Copy link
Copy Markdown
Member

It will be interesting to see what test timing looks like here, particularly for massive stars and larger nets. I think this could make the Skye EOS calls potentially 1-2 orders of magnitude more expensive, so at least some tests might show a noticeable slowdown. Have you done any local testing with timings reported?

I think there was some discussion about pushing this lower when Skye was being developed, but I can't remember specifically why we didn't go lower than 1d-4. Maybe a conservative choice. I think this was inherited from an older default mass_fraction_limit_for_PC = 1d-3, and we were already pushing an order of magnitude lower than that.

@Debraheem

Copy link
Copy Markdown
Member Author

I haven't noticed any timing difference, and i've been doing this locally for a quite a while. I think "fix_d_eos_dxa_partials = .true." is the real costly operation at the moment. But let's keep an eye on those tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eos Equation of state module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants