Skip to content

Remove DueCredit#54

Merged
eurunuela merged 1 commit intoME-ICA:mainfrom
eurunuela:bibtex
Jan 5, 2023
Merged

Remove DueCredit#54
eurunuela merged 1 commit intoME-ICA:mainfrom
eurunuela:bibtex

Conversation

@eurunuela
Copy link
Copy Markdown
Collaborator

@eurunuela eurunuela commented Jan 5, 2023

This PR closes #53.

Follow-up work of adding BibTex citations should happen in #46.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 5, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.26%. Comparing base (90ca567) to head (0a86057).
⚠️ Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   90.30%   90.26%   -0.04%     
==========================================
  Files           3        3              
  Lines         299      298       -1     
==========================================
- Hits          270      269       -1     
  Misses         29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eurunuela eurunuela changed the title Remove DueCredit and use BibTex Remove DueCredit Jan 5, 2023
@eurunuela eurunuela requested a review from tsalo January 5, 2023 13:18
Copy link
Copy Markdown
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It looks like duecredit wasn't actually being used, so there are no specific citations to remove.

@eurunuela
Copy link
Copy Markdown
Collaborator Author

LGTM. It looks like duecredit wasn't actually being used, so there are no specific citations to remove.

That's right, but it was being imported by __init__.py, which is why I believe we could still see it when running tedana.

@eurunuela eurunuela merged commit 45837f9 into ME-ICA:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove DueCredit dependency

3 participants