DOC: fix doctest output in transformations.py for newer NumPy#5283
DOC: fix doctest output in transformations.py for newer NumPy#5283Kd1880 wants to merge 5 commits intoMDAnalysis:developfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on GitHub Discussions so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS as part of this PR.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5283 +/- ##
========================================
Coverage 93.82% 93.82%
========================================
Files 180 182 +2
Lines 22477 22483 +6
Branches 3191 3195 +4
========================================
+ Hits 21089 21095 +6
Misses 925 925
Partials 463 463 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IAlibay
left a comment
IAlibay
left a comment
There was a problem hiding this comment.
You removed the AI and other declarations from the PR template. Please add them before we review this PR.
BradyAJohnston
left a comment
BradyAJohnston
left a comment
There was a problem hiding this comment.
Please use the template available in the repo (https://github.com/MDAnalysis/mdanalysis/blob/develop/.github/PULL_REQUEST_TEMPLATE.md).
It pre-fills when you open a PR on GitHub. Currently you have the changelog message from your other PR also in this PR. Please also update your other PR if you wish for us to review it.
jeremyleung521
left a comment
jeremyleung521
left a comment
There was a problem hiding this comment.
A couple changes needed.
|
|
||
| Fixes | ||
| * Fixes TypeError with np.int64 indexing in GSD Reader (Issue #5224) | ||
| * Fix doctest output in transformations.py for newer NumPy |
There was a problem hiding this comment.
Your changes deleted someone else's line. Please restore that.
Also the two lines you added should be a single line.
| - Kushagar Garg | ||
| - Jeremy M. G. Leung | ||
| - Harshit Gajjela | ||
| - Kriti Dogra |
There was a problem hiding this comment.
Place your name at the bottom of the list.
4 participants
Fixes part of #3925
Changes made in this Pull Request:
decompose_matrix()intransformations.pynp.float64(0.123)instead of0.123LLM / AI generated code disclosure
LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: yes
(Claude by Anthropic was used to help identify and understand the fix. Actual code changes were made manually.)
PR Checklist
package/CHANGELOGfile updated?package/AUTHORS?Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.