reorder pages in sidebar#458
Conversation
orbeckst
left a comment
orbeckst
left a comment
There was a problem hiding this comment.
Fine with me.
(Eventually it would be good to condense even more or use foldable submenus.)
micaela-matta
left a comment
micaela-matta
left a comment
There was a problem hiding this comment.
Thanks @namiroues for implementing the changes we discussed in our meeting 🙏
github-project-automation
Bot
moved this from Todo
to In Progress
in Streamlining Documentation (SDG23)
|
Following up on the meeting suggestions by @micaela-matta and @jennaswa the new order is now: Home Also, the core pages have been moved to the top level. |
orbeckst
left a comment
orbeckst
left a comment
There was a problem hiding this comment.
Changes look fine to me. I like the lifting of core pages to top level. It just has the potential to break a lot of links. Some of these will be external links into our site and we'll just have to deal with this as we go along but if there's a way to check the whole site for broken links after the change then we should do that – can you raise an issue for doing that, please?
Could you please also check the wiki pages that deal with GSOC and update links there, in case they break?
|
Thanks, @namiroues ! Looking at it all together (and sorry to get so nitpicky on these things), Events seems like a sub-category to Community to me, and would make slightly more sense to me just below Community, but I don't feel too strongly here. If we do ultimately get around to doing a collapsable sidebar, this could be an example of where pages could potentially be condensed/combined further. |
|
I resolved the conflicts @micaela-matta. Could you please check and merge? Thank you. |
jennaswa
left a comment
jennaswa
left a comment
There was a problem hiding this comment.
Thank you so much for the hard work on this @namiroues! I think it looks great and am happy with the main goal of this PR (i.e., the sidebar order). However, I've left a couple of suggestions/comments for resolution before I would say this is ready to merge.
|
@namiroues do you think you'll be able to complete this PR? You've already put a lot of work into it and it would be great to have the updates go live. |
|
Apologies for the delay in this work @orbeckst . I've been really busy lately but I am planning to complete it this week so we can close this PR. |
|
@jennaswa did @namiroues address your comments or is there anything major left to do? @namiroues would you be able to resolve the conflict that prevents a clean merge of the PR? |
namiroues
force-pushed
the
reorder-pages-in-sidebar
branch
from
0c36e8b to
44e988f
Compare
|
Thank you @namiroues ! |
|
@jennaswa could you please have a quick look at this PR and decide if your comments have been addressed? |
jennaswa
left a comment
jennaswa
left a comment
There was a problem hiding this comment.
LGTM -- thank you so much for all of your hard work on this, @namiroues! It looks to me that the major items have been addressed. I say let's get this merged, and create new issues/smaller PRs if there are any outstanding issues.
|
@namiroues sorry to ping you — could you please resolve the conflicts that have come up? Once this is done I am happy to merge. Thank you! |
|
@namiroues - Hope you are doing well! I wanted to check-in on whether you might have some time to resolve the conflicts in this PR so we can get this merged. Thanks again for all your work on this, and let us know if you need anything from our end! |
5 participants
Pages on sidebar are in this order now:
Home
Getting Started
Learning MDAnalysis
Documentation
MDAKits and MDA-based tools
Contribute
Community
Events
Citations
About MDAnalysis
MDAnalysis team
Blog
Privacy Policy