Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #164 +/- ##
==========================================
+ Coverage 88.20% 88.59% +0.38%
==========================================
Files 5 5
Lines 814 833 +19
Branches 107 107
==========================================
+ Hits 718 738 +20
- Misses 56 57 +1
+ Partials 40 38 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
@orbeckst pls check this kindly |
orbeckst
requested changes
Mar 16, 2026
Member
orbeckst
left a comment
There was a problem hiding this comment.
This is already looking pretty good. Please also add doc strings and update CHANGELOG. Will have a closer look once this is done. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is regarding #161
Implemented from_grid() a static method and native (property) inside OpenDX.py and mrc.py