Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
View all resources
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  GitHub Stars
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

MCR-Digital / apprentice-boot-camp-improving-code Public

Notifications You must be signed in to change notification settings
Fork 66
Star 0

Code
Issues 12
Pull requests 9
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

Code review exercise: Shu Wang#117

Open

shugewang wants to merge 19 commits intoMCR-Digital:masterMCR-Digital/apprentice-boot-camp-improving-code:masterfrom

shugewang:mastershugewang/apprentice-boot-camp-improving-code:masterCopy head branch name to clipboard

Conversation Commits19 (19)Checks Files changed

Open

Code review exercise: Shu Wang#117
shugewang wants to merge 19 commits intoMCR-Digital:masterfrom
shugewang:master

Commits

Commits on Jan 8, 2024

Refactor uncommunicative names
shugewang
committed
Refactor duplicate code
shugewang
committed
refactor: extract variable
shugewang
committed
refactor duplicate code
shugewang
committed
refactor: extract magic number
shugewang
committed
rename constants
shugewang
committed

Commits on Jan 9, 2024

refactor: extract addCoin(), updateCurrentPlayer() and shouldGameContinue() into one method
shugewang
committed
refactor: decompose conditional
shugewang
committed
refactor: extract isRollOdd as method instead of variable
shugewang
committed
refactor: extract Board, Player and Place classes
shugewang
committed
refactor: take places out of Game class
shugewang
committed
refactor: extract places property to Player class as position
shugewang
committed
remove now unused getNumberOfPlayers() method
shugewang
committed
refactor: changed currentCategory() to be less coupled to Game class
shugewang
committed
refactor: move question category logic to Place class
shugewang
committed
refactor: extract questions to QuestionBank class
shugewang
committed
refactor: convert string concat to template, split updateRoundAndCheckIfShouldContinue() into separate methods
shugewang
committed
refactor: extract currentPlayer into field on Game class
shugewang
committed
refactor: move askQuestion() into QuestionBank class
shugewang
committed

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.