Handle extended colour codes#332
Open
kurahaupo wants to merge 7 commits intoMCMrARM:masterfrom
Open
Conversation
Contributor
kurahaupo
commented
Oct 4, 2022
kurahaupo
commented
- handle mIRC extended colour codes 16~98
- handle ANSI escape-sequences for colour codes and other attributes
Contributor
Author
|
(please squash before merging) |
Contributor
Author
|
This patch also fixes a bug where a digit following a colour code would sometimes be taken to be part of that code. (It ensures that when sending a colour code, it always ends with two digits when it's followed by a literal digit). It also applies some minor optimisations to send bold/italic/underline to reset those attributes (since they're defined to be toggles), rather than sending a reset and the have to re-enable all other attributes. (It still sends a reset when intending to reach the default state, to minimise the effects in other clients that might mishandle toggled attribute.) |
kurahaupo
force-pushed
the
patch-kurahaupo-3
branch
from
615577d to
9a9eef7
Compare
kurahaupo
force-pushed
the
patch-kurahaupo-3
branch
from
9a9eef7 to
c3de2ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.