Fix axiom schematics crashing the plot#208
Merged
StackDoubleFlow merged 4 commits intoMCHPR:masterfrom Mar 25, 2026
Merged
Conversation
Member
|
At some point we should also handle cases where those fields don't exist at all. The Sponge Schematic Specification actually specifies |
StackDoubleFlow
requested changes
Oct 21, 2025
Member
StackDoubleFlow
left a comment
StackDoubleFlow
left a comment
There was a problem hiding this comment.
Thanks for fixing this
BramOtte
force-pushed
the
axiom-schematics-offset
branch
from
f95ba20 to
c358e03
Compare
Contributor
Author
|
I accidentally clicked request review, don't merge this until I have done tests. |
Contributor
Author
|
I have done some rudimentary tests, loading in mpu7, mpu8, iris (various ages of worldedit schematics) and a simple Axiom schematic all seem to load correctly now |
… property for sponge version 2
…set, and remove inaccurate Axiom comment also makes the project rust 2024 to make use of new `if let` syntax
BramOtte
force-pushed
the
axiom-schematics-offset
branch
from
0195a15 to
d97d65c
Compare
StackDoubleFlow
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason Axiom uses the version 3 format for the offset but specifies version 2, thus trying to load in a schematic generated by the Axiom mod would crash the plot.
This fixes that by also checking for the Offset property for sponge version 2.