GH-598: second QA fix - first review

[bertllll]

Note

High Risk
Touches payment/scan orchestration and transaction pricing logic (retry amounts and gas price computation), which can directly affect on-chain payouts and automated recovery after failures.

Overview
Accountant scanning/retry behavior is refactored and tightened. Receivable scans are rescheduled only when appropriate (e.g., no UI response), start-scan error handling is centralized via UnableToStartScanner, and retry-payable scans are now scheduled via notify_later with an explicit interval.

Retry transaction generation/pricing is changed. Retry templates now replace the retry amount with the latest payable balance (instead of adding), add detailed debug logging, and adjust gas-price logic to use increase_by_percentage with a fallback constant increment when the latest gas price drops; new constants DEFAULT_GAS_PRICE_RETRY_PERCENTAGE and DEFAULT_GAS_PRICE_RETRY_CONSTANT are introduced.

CLI/tests/infra updates. Adds --new-public-key (on|off) and unifies on/off parsing via a shared OnOff enum, updates integration tests to hit www.testingmcafeesites.com endpoints, fixes failed-payable SQL matching for RecheckRequired, bumps crate versions to 0.9.1, updates gitignores, and switches CI macOS runner to macos-latest.

^{Written by Cursor Bugbot for commit 8bd5a40. This will update automatically on new commits. Configure here.}

[utkarshg6]

Perhaps you could add more details to this log, using the contents of the error.

[cursor]

Bug: Insufficient logging detail in scan error handler (Bugbot Rules)

The debug log in acknowledge_scan_error logs a generic message without including error details. The PR reviewer explicitly requested adding more details using the contents of the error parameter, which contains scan_type, response_skeleton_opt, and msg fields that would aid debugging. The commit adds the log but doesn't incorporate the error's contents as requested.

 

[cursor]

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix prepared fixes for both issues found in the latest run.

• ✅ Fixed: Log message omits error content details
  • Updated acknowledge_scan_error to include the full ScanError payload in the debug log for better traceability.
• ✅ Fixed: Test uses moved value in second assertion
  • Changed the UTF-8 debug message conversions to use cloned response buffers so the original vectors remain available across both assertions.

Or push these changes by commenting:

@cursor push 42494c425a

Preview (42494c425a)

diff --git a/multinode_integration_tests/tests/data_routing_test.rs b/multinode_integration_tests/tests/data_routing_test.rs
--- a/multinode_integration_tests/tests/data_routing_test.rs
+++ b/multinode_integration_tests/tests/data_routing_test.rs
@@ -330,7 +330,7 @@
             .is_some(),
             true,
             "Actual response:\n{}",
-            String::from_utf8(one_response).unwrap()
+            String::from_utf8(one_response.clone()).unwrap()
         );
         assert_eq!(
             index_of(
@@ -341,7 +341,7 @@
                 .is_some(),
             true,
             "Actual response:\n{}",
-            String::from_utf8(one_response).unwrap()
+            String::from_utf8(one_response.clone()).unwrap()
         );
     }
     {
@@ -353,7 +353,7 @@
             .is_some(),
             true,
             "Actual response:\n{}",
-            String::from_utf8(another_response).unwrap()
+            String::from_utf8(another_response.clone()).unwrap()
         );
         assert_eq!(
             index_of(
@@ -364,7 +364,7 @@
                 .is_some(),
             true,
             "Actual response:\n{}",
-            String::from_utf8(another_response).unwrap()
+            String::from_utf8(another_response.clone()).unwrap()
         );
     }
 }

diff --git a/node/src/accountant/scanners/mod.rs b/node/src/accountant/scanners/mod.rs
--- a/node/src/accountant/scanners/mod.rs
+++ b/node/src/accountant/scanners/mod.rs
@@ -266,7 +266,10 @@
     }
 
     pub fn acknowledge_scan_error(&mut self, error: &ScanError, logger: &Logger) {
-        debug!(logger, "Acknowledging a scan that couldn't finish");
+        debug!(
+            logger,
+            "Acknowledging a scan that couldn't finish: {:?}", error
+        );
         match error.scan_type {
             DetailedScanType::NewPayables | DetailedScanType::RetryPayables => {
                 self.payable.mark_as_ended(logger)

_{This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.}

[cursor]

Log message omits error content details

Low Severity

The new debug log "Acknowledging a scan that couldn't finish" in acknowledge_scan_error doesn't include the contents of the error: &ScanError parameter. The PR reviewer (@utkarshg6) specifically requested: "Perhaps you could add more details to this log, using the contents of the error." Including error in this log message would help with debugging since context can be lost between the error log at the caller and this acknowledgment.