[Docs] Fix enemy condition variables and missing kind fields#22
Open
[Docs] Fix enemy condition variables and missing kind fields#22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrections to the enemies documentation section, identified during the rotating review of the enemies area.
Files Changed
docs/enemies/enemy-structure.mdbuffStacks('BuffName')andhasBuff('BuffName')— these functions do not exist. Buff stacks are accessed directly as variables by name (e.g.,Rage >= 3).round— this is not a valid condition variable (it is not in the combat statistics set and is not injected bygetVariablesFromEntity).enemyhp/enemymaxhpwithtarget.hp/target.maxhp— the correct dot-notation syntax supported by the expression evaluator.docs/enemies/behavior-patterns.mdrotationOverridesexamples missingkind: 'single'— TheSingleStanceinterface requires thekinddiscriminant field. The following patterns were missing it:docs/enemies/design-guide.mdkindon stance rules:rotationOverridesentries — addedkind: 'single'to both entriesstanceRotation— addedkind: 'single'stanceRotation— addedkind: 'single'Game Changes (Reactive)
No modding-relevant game changes were pushed in the past 24 hours. All commits in the review window were translation/typo fixes and UI updates.
Notes for Modders
buffStacks(),hasBuff(),enemyhp, orenemymaxhpin condition strings, update them to use buff names directly andtarget.<stat>notation.rotationOverridesorstanceRotationentries withoutkind, TypeScript will now correctly flag them. Addkind: 'single'to each entry.🤖 Mod Documentation Updater — automated AI assistant