Skip to content

[Docs] Fix enemy condition variables and missing kind fields#22

Open
Lyeeedar wants to merge 1 commit intomainfrom
docs/update-20260401-160547
Open

[Docs] Fix enemy condition variables and missing kind fields#22
Lyeeedar wants to merge 1 commit intomainfrom
docs/update-20260401-160547

Conversation

@Lyeeedar
Copy link
Copy Markdown
Owner

@Lyeeedar Lyeeedar commented Apr 1, 2026

Summary

Corrections to the enemies documentation section, identified during the rotating review of the enemies area.

Files Changed

docs/enemies/enemy-structure.md

  • Fixed Condition Expressions section — The previous version documented three non-existent APIs:
    • Removed buffStacks('BuffName') and hasBuff('BuffName') — these functions do not exist. Buff stacks are accessed directly as variables by name (e.g., Rage >= 3).
    • Removed round — this is not a valid condition variable (it is not in the combat statistics set and is not injected by getVariablesFromEntity).
    • Replaced enemyhp / enemymaxhp with target.hp / target.maxhp — the correct dot-notation syntax supported by the expression evaluator.
  • Updated examples to match the corrected variable names.

docs/enemies/behavior-patterns.md

  • Fixed four rotationOverrides examples missing kind: 'single' — The SingleStance interface requires the kind discriminant field. The following patterns were missing it:
    • "Reactive Counters" section
    • "Stat-Based Responses" section
    • "Resource Management" section
    • "Tournament Fighter" example at end of file

docs/enemies/design-guide.md

  • Fixed three examples missing kind on stance rules:
    • "Multi-Setup Chain" rotationOverrides entries — added kind: 'single' to both entries
    • "Stacking Buffer Template" stanceRotation — added kind: 'single'
    • "Tournament Cultivator Template" stanceRotation — added kind: 'single'

Game Changes (Reactive)

No modding-relevant game changes were pushed in the past 24 hours. All commits in the review window were translation/typo fixes and UI updates.

Notes for Modders

  • Breaking if you relied on the wrong variables: If you used buffStacks(), hasBuff(), enemyhp, or enemymaxhp in condition strings, update them to use buff names directly and target.<stat> notation.
  • TypeScript compile errors: If you wrote rotationOverrides or stanceRotation entries without kind, TypeScript will now correctly flag them. Add kind: 'single' to each entry.

🤖 Mod Documentation Updater — automated AI assistant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant