[Docs] Document buffTarget initialState and tooltipCondition in Scaling - #138
Open
Lyeeedar wants to merge 1 commit into
Open
[Docs] Document buffTarget initialState and tooltipCondition in Scaling#138Lyeeedar wants to merge 1 commit into
Lyeeedar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two documentation gaps found during the 2026-08-14 rotating review of the concepts area:
1.
buffTargettechnique effectinitialState(modapi.md)Commit
0f16b6e7(2026-08-11) addedinitialState?: Record<string, Scaling>toCreateBuffTargetEffect(src/types/buff.ts) andBuffTargetTechniqueEffect(src/types/technique.ts). This field seeds a buff'sinternalStateat application time using expressions evaluated in the applier's context, enabling debuffs that capture apply-time data (e.g. absorbed damage). The feature mirrorsinitialStatealready available onbuffSelf. The documentation did not mention this field at all.Added a new "Technique Effect Reference" section with a
buffTargetentry covering the field and an example use case.2. Missing
tooltipConditionfield inScalinginterface (scaling.md)src/types/stat.tsdefinestooltipCondition?: stringon theScalinginterface — it controls whether a scaling value is shown in buff tooltips. This field was absent from the documented interface.Added the field with its description to the
Scalinginterface block in scaling.md.🤖 Mod Documentation Updater — automated AI assistant