[Docs] Add initialState and hideBuff to buffTarget effect docs - #137
Open
Lyeeedar wants to merge 1 commit into
Open
[Docs] Add initialState and hideBuff to buffTarget effect docs#137Lyeeedar wants to merge 1 commit into
Lyeeedar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
buffTargeteffect documentation indocs/combat/effects.mdto reflect a recent game change.Changes
docs/combat/effects.mdbuffTarget: AddedhideBuff?: trueandinitialState?: Record<string, Scaling>to the type signature and code example. Added explanatory note linking to the existinginitialStateonbuffSelf.Game Change Trigger
Commit
0f16b6e7b— ModAPI: add initialState property to the CreateBuffTargetEffect like in the CreateBuffSelfEffect (#8736)The
initialStateproperty was added toCreateBuffTargetEffect(buff effect) andBuffTargetTechniqueEffect(technique effect), matching the field already present onbuffSelf. This allows modders to seed a debuff'sinternalStatewith values computed from the technique's scaling context at application time.Rotating Review
This run reviewed the combat area (effects documentation).
🤖 Mod Documentation Updater — automated AI assistant