feat: show standard OMP sessions in view-only mode#98
Conversation
# Conflicts: # docs/OMP_BRIDGE.md # docs/adr/013-t4-host-ownership.md
# Conflicts: # apps/desktop/src/service.ts # apps/desktop/test/desktop-lifecycle.test.ts
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
riverpilot
left a comment
There was a problem hiding this comment.
Not merge-ready:
- The branch is 131 commits behind
main, conflicts, and must be rebased against the current official-OMP authority work. - The fallback constructs
FileSessionDiscoveryfrom the configured root without rejecting symlinked JSONL entries or proving each canonical file remains beneath the canonical root. A*.jsonlsymlink can expose a transcript outside--session-rootthrough list/load/search. Reject symlinked entries and enforce canonical-root containment, with a regression test.
Current main's opt-in official-OMP authority does not make this exact automatic fallback redundant, so close if that product behavior is no longer desired; otherwise repair and rebase.
|
Implemented the requested symlink rejection and canonical session-root containment directly on current main in #134; host-service typecheck and all 330 tests pass. The original compatibility branch is superseded by current official authority mode and remains conflicted, so please close #98 rather than merging it. |
|
Closing without merge. Current main's official OMP authority supersedes this stale compatibility branch, and the required transcript symlink/canonical-root hardening has landed independently in #134. |
Summary
OMP · view onlywith explicit limitations in the transcript and controlsSafety boundary
Compatibility mode never starts an OMP worker and rejects prompt, control, and session-management commands at the host even if the UI is bypassed. It does not claim running, idle, or ownership status that standard OMP cannot provide.
Verification
pnpm checkpnpm testpnpm build:webpnpm build:hostStacked on #95 because that PR introduces the standalone
t4-hostfallback point.