Upload isCharging in uploader device status#26
Merged
Conversation
Populate the new UploaderStatus.isCharging flag from the device battery state so the Nightscout device status reflects whether the uploading device is on power. A full battery counts as charging, matching iOS battery state semantics where a plugged-in device at 100% reports .full rather than .charging.
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Populates the
isChargingflag on theuploadersection of the Nightscout device status from the device's battery state, so consumers (e.g. LoopFollow) can show whether the uploading device is currently on power.A full battery counts as charging, matching iOS battery state semantics: a plugged-in device at 100% reports
.fullrather than.charging. The flag is only set when battery monitoring is enabled; otherwise it is omitted. The key nameisChargingmatches the field already produced by Trio and consumed by LoopFollow.Depends on LoopKit/NightscoutKit#2, which adds
isChargingtoUploaderStatus.