Skip to content

fix: remove browser UA spoofing for ChatGPT API requests #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Loongphy merged 3 commits into from
May 28, 2026
+7 −6
Merged

fix: remove browser UA spoofing for ChatGPT API requests #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7221275
fix: remove browser UA spoofing for ChatGPT API requests
Loongphy May 28, 2026
bc47eff
Apply suggestion from @greptile-apps[bot]
Loongphy May 28, 2026
bf66e54
fix: update remaining browser_user_agent references to user_agent
Loongphy May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/api/http.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ pub const request_timeout_ms = types.request_timeout_ms;
pub const request_timeout_ms_value = types.request_timeout_ms_value;
pub const child_process_timeout_ms = types.child_process_timeout_ms;
pub const child_process_timeout_ms_value = types.child_process_timeout_ms_value;
pub const browser_user_agent = types.browser_user_agent;
pub const user_agent = types.user_agent;
pub const node_executable_env = types.node_executable_env;
pub const node_use_env_proxy_env = types.node_use_env_proxy_env;
pub const node_requirement_hint = types.node_requirement_hint;
Expand Down
8 changes: 4 additions & 4 deletions src/api/http_node.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const BatchItemResult = types.BatchItemResult;
const request_timeout_ms = types.request_timeout_ms;
const request_timeout_ms_value = types.request_timeout_ms_value;
const child_process_timeout_ms_value = types.child_process_timeout_ms_value;
const browser_user_agent = types.browser_user_agent;
const user_agent = types.user_agent;
const getEnvMap = env.getEnvMap;
const resolveNodeExecutable = executable.resolveNodeExecutable;
const resolveNodeExecutableForLaunchAlloc = executable.resolveNodeExecutableForLaunchAlloc;
Expand Down Expand Up @@ -266,7 +266,7 @@ fn runNodeBearerGetJsonCommand(
endpoint,
access_token,
request_timeout_ms,
browser_user_agent,
user_agent,
}, child_process_timeout_ms_value, &env_map) catch |err| switch (err) {
error.OutOfMemory => return err,
error.FileNotFound => {
Expand Down Expand Up @@ -334,7 +334,7 @@ fn runNodeGetJsonCommand(
access_token,
account_id,
request_timeout_ms,
browser_user_agent,
user_agent,
}, child_process_timeout_ms_value, &env_map) catch |err| switch (err) {
error.OutOfMemory => return err,
error.FileNotFound => {
Expand Down Expand Up @@ -411,7 +411,7 @@ fn runNodeGetJsonBatchCommand(
.endpoint = endpoint,
.timeout_ms = request_timeout_ms_value,
.concurrency = @max(@as(usize, 1), max_concurrency),
.user_agent = browser_user_agent,
.user_agent = user_agent,
.requests = requests,
}, .{}, &payload_writer.writer);

Expand Down
3 changes: 2 additions & 1 deletion src/api/http_types.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
const std = @import("std");
const version = @import("../version.zig");

pub const request_timeout_secs: []const u8 = "5";
pub const request_timeout_ms: []const u8 = "5000";
pub const request_timeout_ms_value: u64 = 5000;
pub const child_process_timeout_ms: []const u8 = "7000";
pub const child_process_timeout_ms_value: u64 = 7000;
pub const browser_user_agent: []const u8 = "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/136.0.0.0 Safari/537.36";
pub const user_agent: []const u8 = "codex-auth/" ++ version.app_version;
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Build-breaking rename — two call sites not updated

browser_user_agent was renamed to user_agent here, but src/api/http.zig (line 14) and src/api/http_node.zig (line 16) still import types.browser_user_agent. Because that symbol no longer exists in http_types.zig, both files will fail to compile. The rename must be propagated to every reference, including the aliased re-exports in http.zig and the local binding + all three use-sites in http_node.zig (lines 16, 269, 337, 414).

Prompt To Fix With AI 
This is a comment left during a code review.
Path: src/api/http_types.zig
Line: 9

Comment:
**Build-breaking rename — two call sites not updated**

`browser_user_agent` was renamed to `user_agent` here, but `src/api/http.zig` (line 14) and `src/api/http_node.zig` (line 16) still import `types.browser_user_agent`. Because that symbol no longer exists in `http_types.zig`, both files will fail to compile. The rename must be propagated to every reference, including the aliased re-exports in `http.zig` and the local binding + all three use-sites in `http_node.zig` (lines 16, 269, 337, 414).

How can I resolve this? If you propose a fix, please make it concise.

Fix in Codex

pub const node_executable_env = "CODEX_AUTH_NODE_EXECUTABLE";
pub const node_use_env_proxy_env = "NODE_USE_ENV_PROXY";
pub const node_requirement_hint = "Node.js 22+ is required for ChatGPT API refresh. Install Node.js 22+ or use the npm package.";
Expand Down
Loading