Skip to content

refactor(Windows): mark protocol headers C++-only - #73

Open
ReenigneArcher wants to merge 1 commit into
masterfrom
fix/release-prep-05
Open

refactor(Windows): mark protocol headers C++-only#73
ReenigneArcher wants to merge 1 commit into
masterfrom
fix/release-prep-05

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Update the shared Windows protocol headers to explicitly be C++-only and remove legacy C compatibility paths. This drops the #else constant/enums and extern "C" wrappers, leaving a single C++ definition path with inline constexpr, scoped enums, and the existing packed protocol structs.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 30.43478% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.70%. Comparing base (605bf93) to head (8a26ec7).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/platform/windows/windows_license.cpp 0.00% 15 Missing ⚠️
src/platform/windows/windows_backend.cpp 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   74.76%   74.70%   -0.07%     
==========================================
  Files          33       33              
  Lines        7910     7906       -4     
  Branches     2968     2966       -2     
==========================================
- Hits         5914     5906       -8     
+ Misses       1658     1421     -237     
- Partials      338      579     +241     
Flag Coverage Δ
FreeBSD 50.96% <100.00%> (ø)
Linux-Clang 56.64% <100.00%> (ø)
Linux-GCC 67.52% <100.00%> (ø)
Windows-MSVC 87.90% <100.00%> (-0.17%) ⬇️
Windows-MinGW-UCRT64 64.28% <30.43%> (+0.03%) ⬆️
macOS 50.28% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/windows/control_protocol.hpp 100.00% <100.00%> (ø)
...rm/windows/shared/playstation_feature_protocol.hpp 95.09% <100.00%> (ø)
src/platform/windows/windows_broker_client.hpp 80.00% <100.00%> (ø)
src/platform/windows/windows_backend.cpp 84.05% <50.00%> (-0.65%) ⬇️
src/platform/windows/windows_license.cpp 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 605bf93...8a26ec7. Read the comment docs.

@ReenigneArcher
ReenigneArcher force-pushed the fix/release-prep-05 branch 2 times, most recently from 0d50743 to 2329208 Compare August 14, 2026 03:44
Update the shared Windows protocol headers to explicitly be C++-only and remove legacy C compatibility paths. This drops the `#else` constant/enums and `extern "C"` wrappers, leaving a single C++ definition path with `inline constexpr`, scoped enums, and the existing packed protocol structs.
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant