Skip to content

refactor: sonar fixes #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReenigneArcher merged 1 commit into from
Aug 13, 2026
+9 −8
Merged

refactor: sonar fixes #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/platform/linux/uhid_backend.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1079,7 +1079,7 @@ namespace lvh::detail {
return status;
}

std::vector<int> buttons {BTN_TOUCH, BTN_STYLUS, BTN_STYLUS2, BTN_TOOL_PEN, BTN_TOOL_RUBBER, BTN_TOOL_BRUSH, BTN_TOOL_PENCIL, BTN_TOOL_AIRBRUSH};
std::vector buttons {BTN_TOUCH, BTN_STYLUS, BTN_STYLUS2, BTN_TOOL_PEN, BTN_TOOL_RUBBER, BTN_TOOL_BRUSH, BTN_TOOL_PENCIL, BTN_TOOL_AIRBRUSH};
#if defined(BTN_STYLUS3)
buttons.push_back(BTN_STYLUS3);
#endif
Expand Down
15 changes: 8 additions & 7 deletions src/shared/playstation_feature_reports.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#pragma once

// standard includes
#include <array>
#include <cstdint>

namespace lvh::detail::playstation_feature_reports {
Expand All @@ -18,7 +19,7 @@ namespace lvh::detail::playstation_feature_reports {
inline constexpr std::uint8_t dualsense_pairing_report = 0x09;
inline constexpr std::uint8_t dualsense_firmware_report = 0x20;

inline constexpr std::uint8_t dualshock4_usb_calibration_info[] {
inline constexpr std::array<std::uint8_t, 37> dualshock4_usb_calibration_info {
0x02,
0x00,
0x00,
Expand Down Expand Up @@ -58,7 +59,7 @@ namespace lvh::detail::playstation_feature_reports {
0x00,
};

inline constexpr std::uint8_t dualshock4_bluetooth_calibration_info[] {
inline constexpr std::array<std::uint8_t, 41> dualshock4_bluetooth_calibration_info {
0x05,
0x00,
0x00,
Expand Down Expand Up @@ -102,7 +103,7 @@ namespace lvh::detail::playstation_feature_reports {
0x00,
};

inline constexpr std::uint8_t dualshock4_firmware_info[] {
inline constexpr std::array<std::uint8_t, 49> dualshock4_firmware_info {
0xA3,
0x41,
0x75,
Expand Down Expand Up @@ -154,7 +155,7 @@ namespace lvh::detail::playstation_feature_reports {
0x00,
};

inline constexpr std::uint8_t dualshock4_pairing_info[] {
inline constexpr std::array<std::uint8_t, 16> dualshock4_pairing_info {
0x12,
0x00,
0x00,
Expand All @@ -173,7 +174,7 @@ namespace lvh::detail::playstation_feature_reports {
0x00,
};

inline constexpr std::uint8_t dualsense_calibration_info[] {
inline constexpr std::array<std::uint8_t, 41> dualsense_calibration_info {
0x05,
0x00,
0x00,
Expand Down Expand Up @@ -217,7 +218,7 @@ namespace lvh::detail::playstation_feature_reports {
0x00,
};

inline constexpr std::uint8_t dualsense_firmware_info[] {
inline constexpr std::array<std::uint8_t, 64> dualsense_firmware_info {
0x20,
0x4A,
0x75,
Expand Down Expand Up @@ -284,7 +285,7 @@ namespace lvh::detail::playstation_feature_reports {
0x00,
};

inline constexpr std::uint8_t dualsense_pairing_info[] {
inline constexpr std::array<std::uint8_t, 20> dualsense_pairing_info {
0x09,
0x74,
0xE7,
Expand Down
Loading