fix(linux): use FQDN naming for all Linux packaging types#4779
fix(linux): use FQDN naming for all Linux packaging types#4779ReenigneArcher merged 4 commits intoLizardByte:masterfrom
Conversation
Normalize install files to use the FQDN naming scheme for all package types (native/AppImage/Flatpak) to allow XDG compliance. * Use FQDN naming convention for icons. * Use "app-FQDN" naming convention for unprivileged systemd service; fixes XDG Desktop Portal app_id detection. * Restore privileged "sunshine-kms" service unit back to "sunshine" and restore as the default in documentation and via preset unit. The unprivileged service only needs XDG compliance.
|
These changes are enough to fix XDG detection when streaming via Portal grab, but if we want more complete compliance, the real binary should probably be named "PROJECT_FQDN" as well. Should we change it or leave as-is? Detection works fine on Fedora 43 with the native package and these current changes. |
I think we should change it. Maybe for this one we can create an alias in the post install scripts? |
I'm not sure what kind of alias you mean? XDG detects the app_id using multiple matching strategies, including the name of the executable via /proc/$(pidof sunshine)/exe. This would point to the real file and not a symlink. But it's already matching correctly without this change. |
Disregard, for I was mistakenly thinking this PR was changing the binary name. |
So we'll leave the binary name as-is? I think it's ok. Are you comfortable with the hardcoding of the FQDN in scripts, though? It would cause issues for forks that change to their own FQDN. Should I modify the cmake scripts to replace the strings in these files in the same way that the service files are processed? |
Hardcoding is fine. The configure files was not really meant to help forks anyway. It was more to have less places when an adjustment was made. |
Normalize install files to use the FQDN naming scheme for all package types (native/AppImage/Flatpak) to allow XDG compliance. * Use FQDN naming convention for icons. * Use "app-FQDN" naming convention for unprivileged systemd service; fixes XDG Desktop Portal app_id detection. * Restore privileged "sunshine-kms" service unit back to "sunshine" and restore as the default in documentation and via preset unit. The unprivileged service only needs XDG compliance.
Bundle ReportBundle size has no change ✅ |
|
|
Sorry for the delay on this PR. There was a bunch of build failures that needed to be addressed, but finally caught up now.
Back to this original comment, I guess there was some confusion with the back and forth. I think renaming the binary is a good idea if it makes the project more compliant with standard practices. What I meant by creating an alias is something like This could always be done later if we don't want to do it now though. NOTE: If you do push changes to this PR, I had pushed a fix for the new sonar issues, so please keep that. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4779 +/- ##
==========================================
+ Coverage 16.74% 16.75% +0.01%
==========================================
Files 106 106
Lines 21761 21762 +1
Branches 9736 9737 +1
==========================================
+ Hits 3644 3647 +3
- Misses 15794 16378 +584
+ Partials 2323 1737 -586
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
I will merge and we can decide about the binary name later. |
2 participants
Normalize install files to use the FQDN naming scheme for all package types (native/AppImage/Flatpak) to allow XDG compliance.
Description
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage