Parse timestamp strings in heuristicate-types, issue #14#41
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
|
I think this is generally good, although I'd rather throw an error if |
Author
Done. I've also made it map to a new vector first to prevent inconsistent modifications to the dataframe if an error is signaled halfway through. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This is a draft implementation of the behavior proposed in issue #14. Now
heuristicate-typesreplaces timestamp strings withtimestampobjects usinglocal-time.I've only recently started studying lisp-stat and may miss some details. Please let me know if my approach to this task is correct. I'll be glad to hear any feedback, fix the issues and do all the work necessary to merge this feature.
Alexander Kuzmin