Skip to content

Parse timestamp strings in heuristicate-types, issue #14#41

Merged
snunez1 merged 1 commit into
Lisp-Stat:masterfrom
tre-flip:master
Jun 7, 2026
Merged

Parse timestamp strings in heuristicate-types, issue #14#41
snunez1 merged 1 commit into
Lisp-Stat:masterfrom
tre-flip:master

Conversation

@tre-flip

@tre-flip tre-flip commented Jun 6, 2026

Copy link
Copy Markdown

Hello,

This is a draft implementation of the behavior proposed in issue #14. Now heuristicate-types replaces timestamp strings with timestamp objects using local-time.

I've only recently started studying lisp-stat and may miss some details. Please let me know if my approach to this task is correct. I'll be glad to hear any feedback, fix the issues and do all the work necessary to merge this feature.


Alexander Kuzmin

@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@tre-flip

tre-flip commented Jun 6, 2026

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Jun 6, 2026
@snunez1

snunez1 commented Jun 7, 2026

Copy link
Copy Markdown

I think this is generally good, although I'd rather throw an error if local-time can't parse the string. I.e. we want to catch problems earlier in the pipeline than later.

@tre-flip

tre-flip commented Jun 7, 2026

Copy link
Copy Markdown
Author

I'd rather throw an error if local-time can't parse the string

Done. I've also made it map to a new vector first to prevent inconsistent modifications to the dataframe if an error is signaled halfway through.

@tre-flip tre-flip marked this pull request as ready for review June 7, 2026 06:07
@snunez1 snunez1 merged commit 4a0b488 into Lisp-Stat:master Jun 7, 2026
1 check passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants