This repository was archived by the owner on Jul 9, 2019. It is now read-only.
Unit test for the PasswordGrantExtension #28
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,177 @@ | ||
| <?php | ||
| namespace Majora\Component\OAuth\Tests\GrantType; | ||
|
|
||
| use Majora\Component\OAuth\Entity\LoginAttempt; | ||
| use Majora\Component\OAuth\Exception\InvalidGrantException; | ||
| use Majora\Component\OAuth\GrantType\PasswordGrantExtension; | ||
| use Majora\Component\OAuth\Loader\AccountLoaderInterface; | ||
| use Majora\Component\OAuth\Model\AccountInterface; | ||
| use Majora\Component\OAuth\Model\ApplicationInterface; | ||
| use Prophecy\Argument; | ||
| use Symfony\Component\OptionsResolver\OptionsResolver; | ||
| use Symfony\Component\Security\Core\Encoder\UserPasswordEncoderInterface; | ||
| use Symfony\Component\Security\Core\User\UserInterface; | ||
|
|
||
| /** | ||
| * Unit test class for Majora\Component\OAuth\GrantType\PasswordGrantTypeExtension. | ||
| */ | ||
| class PasswordGrantExtensionTest extends \PHPUnit_Framework_TestCase | ||
| { | ||
| /** | ||
| * Test configureRequestParameters() method. | ||
| */ | ||
| public function testConfigureRequestParameters() | ||
| { | ||
| $optionsResolver = new OptionsResolver(); | ||
| $passwordGrantExtension = new PasswordGrantExtension( | ||
| $this->prophesize(AccountLoaderInterface::class)->reveal(), | ||
| $this->prophesize(UserPasswordEncoderInterface::class)->reveal() | ||
| ); | ||
| $passwordGrantExtension->configureRequestParameters($optionsResolver); | ||
|
|
||
| $actualRequiredOptions = $optionsResolver->getRequiredOptions(); | ||
| $expectedRequiredOptions = ['password', 'username']; | ||
| $this->assertEquals($expectedRequiredOptions, $actualRequiredOptions, '', $delta = 0.0, 10, true); // Not caring about keys | ||
| } | ||
|
|
||
| /** | ||
| * Test grant() method on success | ||
| */ | ||
| public function testSuccessGrant() | ||
| { | ||
| // Mocking AccountInterface | ||
| /** @var AccountInterface $account */ | ||
| $account = $this->prophesize(AccountInterface::class)->reveal(); | ||
|
|
||
| // Mocking AccountLoaderInterface | ||
| $accountLoaderMock = $this->prophesize(AccountLoaderInterface::class); | ||
| $accountLoaderMock | ||
| ->retrieveOnApplicationByUsername(Argument::type(ApplicationInterface::class), 'username_test') | ||
| ->willReturn($account) | ||
| ->shouldBeCalled(); | ||
| /** @var AccountLoaderInterface $accountLoader */ | ||
| $accountLoader = $accountLoaderMock->reveal(); | ||
|
|
||
| // Mocking UserPasswordEncoderInterface | ||
| $userPasswordEncoderMock = $this->prophesize(UserPasswordEncoderInterface::class); | ||
| $userPasswordEncoderMock | ||
| ->isPasswordValid(Argument::type(UserInterface::class), 'password_test') | ||
| ->willReturn(true) | ||
| ->shouldBeCalled(); | ||
| /** @var UserPasswordEncoderInterface $userPasswordEncoder */ | ||
| $userPasswordEncoder = $userPasswordEncoderMock->reveal(); | ||
|
Contributor
There was a problem hiding this comment. fait le dans le constructeur |
||
|
|
||
| $passwordGrantExtension = new PasswordGrantExtension($accountLoader, $userPasswordEncoder); | ||
|
|
||
| // Mocking ApplicationInterface | ||
| $applicationMock = $this->prophesize(ApplicationInterface::class); | ||
| /** @var ApplicationInterface $application */ | ||
| $application = $applicationMock->reveal(); | ||
|
|
||
| // Mocking LoginAttempt | ||
| $loginAttemptMock = $this->prophesize(LoginAttempt::class); | ||
| $loginAttemptMock | ||
| ->getData('username') | ||
| ->willReturn('username_test') | ||
| ->shouldBeCalled(); | ||
| $loginAttemptMock | ||
| ->getData('password') | ||
| ->willReturn('password_test') | ||
| ->shouldBeCalled(); | ||
| /** @var LoginAttempt $loginAttempt */ | ||
| $loginAttempt = $loginAttemptMock->reveal(); | ||
|
|
||
| $actualAccount = $passwordGrantExtension->grant($application, $loginAttempt); | ||
|
Contributor
There was a problem hiding this comment. $actualAccount = $passwordGrantExtension->grant(
$application->reveal(),
$loginAttempt->reveal()
); |
||
| $this->assertSame($account, $actualAccount); | ||
|
Contributor
There was a problem hiding this comment. "Same" est overkill, envoyer une instance différente et néanmoins égale ne casse pas l'interface applicative de ta classe. |
||
| } | ||
|
|
||
| /** | ||
| * Test grant() when it fails loading an account. | ||
| */ | ||
| public function testGrantFailingAccountLoading() | ||
| { | ||
| // Mocking AccountLoaderInterface | ||
| $accountLoaderMock = $this->prophesize(AccountLoaderInterface::class); | ||
| $accountLoaderMock | ||
| ->retrieveOnApplicationByUsername(Argument::type(ApplicationInterface::class), 'username_test') | ||
| ->willReturn(null) | ||
|
Contributor
There was a problem hiding this comment. Pas besoin, par défaut les méthodes mockées renvoient |
||
| ->shouldBeCalled(); | ||
| /** @var AccountLoaderInterface $accountLoader */ | ||
| $accountLoader = $accountLoaderMock->reveal(); | ||
|
|
||
| // Mocking UserPasswordEncoderInterface | ||
| $userPasswordEncoderMock = $this->prophesize(UserPasswordEncoderInterface::class); | ||
| /** @var UserPasswordEncoderInterface $userPasswordEncoder */ | ||
| $userPasswordEncoder = $userPasswordEncoderMock->reveal(); | ||
|
|
||
| $passwordGrantExtension = new PasswordGrantExtension($accountLoader, $userPasswordEncoder); | ||
|
|
||
| // Mocking ApplicationInterface | ||
| $applicationMock = $this->prophesize(ApplicationInterface::class); | ||
| /** @var ApplicationInterface $application */ | ||
| $application = $applicationMock->reveal(); | ||
|
|
||
| // Mocking LoginAttempt | ||
| $loginAttemptMock = $this->prophesize(LoginAttempt::class); | ||
| $loginAttemptMock | ||
| ->getData('username') | ||
| ->willReturn('username_test') | ||
| ->shouldBeCalled(); | ||
| /** @var LoginAttempt $loginAttempt */ | ||
| $loginAttempt = $loginAttemptMock->reveal(); | ||
|
|
||
| $this->expectException(InvalidGrantException::class); | ||
| $passwordGrantExtension->grant($application, $loginAttempt); | ||
| } | ||
|
|
||
| /** | ||
| * Test grant() when it fails to validate the password. | ||
| */ | ||
| public function testGrantFailingPasswordValidation() | ||
| { | ||
| // Mocking AccountInterface | ||
| /** @var AccountInterface $account */ | ||
| $account = $this->prophesize(AccountInterface::class)->reveal(); | ||
|
|
||
| // Mocking AccountLoaderInterface | ||
| $accountLoaderMock = $this->prophesize(AccountLoaderInterface::class); | ||
| $accountLoaderMock | ||
| ->retrieveOnApplicationByUsername(Argument::type(ApplicationInterface::class), 'username_test') | ||
| ->willReturn($account) | ||
| ->shouldBeCalled(); | ||
| /** @var AccountLoaderInterface $accountLoader */ | ||
| $accountLoader = $accountLoaderMock->reveal(); | ||
|
|
||
| // Mocking UserPasswordEncoderInterface | ||
| $userPasswordEncoderMock = $this->prophesize(UserPasswordEncoderInterface::class); | ||
| $userPasswordEncoderMock | ||
| ->isPasswordValid(Argument::type(UserInterface::class), 'password_test') | ||
| ->willReturn(false) | ||
| ->shouldBeCalled(); | ||
| /** @var UserPasswordEncoderInterface $userPasswordEncoder */ | ||
| $userPasswordEncoder = $userPasswordEncoderMock->reveal(); | ||
|
|
||
| $passwordGrantExtension = new PasswordGrantExtension($accountLoader, $userPasswordEncoder); | ||
|
|
||
| // Mocking ApplicationInterface | ||
| $applicationMock = $this->prophesize(ApplicationInterface::class); | ||
| /** @var ApplicationInterface $application */ | ||
| $application = $applicationMock->reveal(); | ||
|
|
||
| // Mocking LoginAttempt | ||
| $loginAttemptMock = $this->prophesize(LoginAttempt::class); | ||
| $loginAttemptMock | ||
| ->getData('username') | ||
| ->willReturn('username_test') | ||
| ->shouldBeCalled(); | ||
| $loginAttemptMock | ||
| ->getData('password') | ||
| ->willReturn('password_test') | ||
| ->shouldBeCalled(); | ||
| /** @var LoginAttempt $loginAttempt */ | ||
| $loginAttempt = $loginAttemptMock->reveal(); | ||
| $this->expectException(InvalidGrantException::class); | ||
|
Contributor
There was a problem hiding this comment. Teste aussi le message de l'exception vu que la classe peut servir dans plusieurs cas. |
||
|
|
||
| $passwordGrantExtension->grant($application, $loginAttempt); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
phpdoc