[codex] skip empty vCard addresses#984
Merged
JulianPrieber merged 1 commit intoJul 4, 2026
Merged
Conversation
chaochaoweb3
force-pushed
the
codex/skip-empty-vcard-addresses
branch
from
3213470 to
b738ea5
Compare
Contributor
Author
|
Rebased this onto the latest upstream main, corrected the commit author metadata, and marked it ready for review. I also triggered a fresh Scrutinizer run; it still reports repository-level analysis errored / tests failed with no artifacts exposed, and the Scrutinizer API shows the tracked main build is already failed. Local validation available here was git diff --check. |
Member
|
Thank you. I will check this soon. Ideally we'll test this in the beta build. |
Contributor
Author
|
Thanks for checking it. I will leave the branch as-is for now; if the beta build shows anything wrong with the vCard address output, I can adjust the patch against that result. |
JulianPrieber
pushed a commit
that referenced
this pull request
Jul 4, 2026
Member
|
The change is included in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The vCard endpoint always called
addAddress()for HOME and WORK. On iOS this can create empty HOME/WORK address entries, making the device try to resolve a location from just the label.Fixes #961.
Validation
git diff --checkphp -l app/Http/Controllers/UserController.phpnot run: PHP is not installed in this local environment