Deploy docs to GitHub Pages on release - #169
Merged
Merged
Conversation
The docs site now tracks the released CLI: the deploy workflow fires on release:published (the same trigger as the PyPI publish) instead of every push to main, and stays manually triggerable via workflow_dispatch for intermediate fixes. Docs hosting consolidates on GitHub Pages — the Cloudflare Workers deployment (wrangler.jsonc was bot autoconfig, not a design decision) is removed, and docs.lightconeresearch.org moves to a custom domain on Pages. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016EL5bESx3CqfMNZNPA1KHJ
❌ Eval Results
GradersNo grader results Full output |
astra-tools 0.2.14 made `astra init` idempotent, adding required check_only/as_json parameters to the callback that this release's `lc init` delegates to — and with no committed lockfile, CI resolves the latest release on every run, so every PR now fails with a TypeError. Pin until the next lightcone-cli major, which no longer calls the callback. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016EL5bESx3CqfMNZNPA1KHJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split out from #168 so the deployment switch can land (and current-main docs can be redeployed) independently of the CLI changes.
docs-deploy.ymlnow triggers onrelease: published— the same moment as the PyPI publish — instead of every push to main, so docs.lightconeresearch.org never documents behaviorpip install lightcone-clican't deliver yet.workflow_dispatchremains for manual intermediate deploys (typo fixes, clarifications) from the Actions tab.wrangler.jsonc(added by the Cloudflare bot's autoconfig PR Add Cloudflare Workers configuration #118, not a design decision) is deleted; the Cloudflare Workers deployment retires.check-docs.ymlis untouched: docs are still build-validated on every merged PR — they just don't ship until a release or a manual dispatch.Manual follow-ups (dashboard-side, can't be done from the repo)
lightcone-cliworker.docs.lightconeresearch.org→lightconeresearch.github.io(DNS-only while GitHub validates).After merging, run the workflow once manually to deploy current main to Pages.
Test plan
zensical build) unchanged and greenrelease: published+workflow_dispatch; build/deploy jobs otherwise identical to what ran before🤖 Generated with Claude Code
https://claude.ai/code/session_016EL5bESx3CqfMNZNPA1KHJ