Fix GViewer BinaryFormatter crash on .NET 9/10; add NuGet package CI#1
Merged
Merged
Conversation
Copilot
AI
changed the title
Fix BinaryFormatter crash on .NET 9/10 in GViewer (merge PR #396)
Fix GViewer BinaryFormatter crash on .NET 9/10; add NuGet package CI
Jun 22, 2026
Copilot created this pull request from a session on behalf of
aschoelzhorn
June 22, 2026 11:51
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GViewer()throwsPlatformNotSupportedExceptionon .NET 9+ becauseGViewer.resxembeds anImageListStreamerserialized viaBinaryFormatter, which was removed in .NET 9. WinForms 9+ handles this natively when targeting the correct TFM — the fix is shipping dedicated TFM binaries.GraphViewerGDI.csprojTargetFrameworks:net472;net6.0-windows→…;net8.0-windows;net9.0-windows;net10.0-windows<GenerateResourceUsePreserializedResources>true</GenerateResourceUsePreserializedResources>— required by the .NET 10 SDK when a project with binary.resxresources also targetsnet472GraphViewerGDI.nuspec<dependencies>groups fornet8.0-windows7.0,net9.0-windows7.0,net10.0-windows7.0<files>entries for the three new TFM DLL/XML outputs.github/workflows/nuget-packages.yml(new)Workflow that builds and packs
Msagl,Msagl.Drawing, andMsagl.GraphViewerGDI, then uploads.nupkgfiles as artifacts. Triggers onv*tag push (version derived from tag) or manualworkflow_dispatchwith explicit version input.