Skip to content

fix: only apply auto fit when load file #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitormattos merged 2 commits into from
Jan 19, 2026
Merged

fix: only apply auto fit when load file #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e075c7
fix: only apply auto fit when load file
vitormattos Jan 19, 2026
212b76e
chore: Bump version
vitormattos Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@libresign/pdf-elements",
"description": "PDF viewer with draggable and resizable element overlays for Vue 2",
"version": "0.2.2",
"version": "0.2.3",
"author": "LibreCode <contact@librecode.coop>",
"private": false,
"main": "dist/pdf-elements.umd.js",
Expand Down
25 changes: 5 additions & 20 deletions src/components/PDFElements.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ export default {
boundHandleWheel: null,
debouncedApplyZoom: null,
visualScale: this.initialScale,
resizeObserver: null,
autoFitApplied: false,
}
},
mounted() {
Expand All @@ -229,17 +229,6 @@ export default {
window.addEventListener('resize', this.onViewportScroll)
this.$el?.addEventListener('scroll', this.onViewportScroll, { passive: true })
this.$el?.addEventListener('wheel', this.boundHandleWheel, { passive: false })
if (this.autoFitZoom) {
window.addEventListener('resize', this.adjustZoomToFit)
if (typeof ResizeObserver !== 'undefined') {
this.resizeObserver = new ResizeObserver(() => {
this.scheduleAutoFitZoom()
})
if (this.$el) {
this.resizeObserver.observe(this.$el)
}
}
}
},
beforeUnmount() {
if (this.zoomRafId) {
Expand All @@ -257,13 +246,6 @@ export default {
window.removeEventListener('scroll', this.onViewportScroll)
window.removeEventListener('resize', this.onViewportScroll)
this.$el?.removeEventListener('scroll', this.onViewportScroll)
if (this.autoFitZoom) {
window.removeEventListener('resize', this.adjustZoomToFit)
if (this.resizeObserver) {
this.resizeObserver.disconnect()
this.resizeObserver = null
}
}
if (this.viewportRafId) {
window.cancelAnimationFrame(this.viewportRafId)
this.viewportRafId = 0
Expand All @@ -273,6 +255,7 @@ export default {
async init() {
if (!this.initFiles || this.initFiles.length === 0) return
const docs = []
this.autoFitApplied = false

for (let i = 0; i < this.initFiles.length; i++) {
const file = this.initFiles[i]
Expand Down Expand Up @@ -852,14 +835,15 @@ export default {
return Math.max(0.1, Math.min(2, availableWidth / maxPageWidth))
},
scheduleAutoFitZoom() {
if (this.autoFitApplied) return
if (this.zoomRafId) return
this.zoomRafId = window.requestAnimationFrame(() => {
this.zoomRafId = 0
this.adjustZoomToFit()
})
},
adjustZoomToFit() {
if (!this.autoFitZoom || !this.pdfDocuments.length) return
if (!this.autoFitZoom || this.autoFitApplied || !this.pdfDocuments.length) return

const widths = this.pdfDocuments
.flatMap(doc => doc.pageWidths || [])
Expand All @@ -881,6 +865,7 @@ export default {
}

const optimalScale = this.calculateOptimalScale(maxCanvasWidth)
this.autoFitApplied = true
if (Math.abs(optimalScale - this.scale) > 0.01) {
this.scale = optimalScale
this.visualScale = optimalScale
Expand Down