Open
Conversation
vitormattos
force-pushed
the
feat/policy-signature-flow-phase1-groundwork
branch
2 times, most recently
from
d422bd0 to
da50ad0
Compare
vitormattos
changed the title
vitormattos
force-pushed
the
feat/policy-signature-flow-phase1-groundwork
branch
from
ccd664a to
6146425
Compare
…tate Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…t auto-highlight Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…y cues Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Add new AddFooterPolicy to the policy system enabling footer visibility control. The policy determines whether the LibreSign footer block is included in signed PDFs. This consolidates footer enablement under the policy-driven architecture. Changes: - Created AddFooterPolicy provider with boolean normalization - Registered provider in PolicyProviders registry - Updated FooterHandler to use policy via PolicyService for runtime enabling/disabling of footer rendering - QR code generation is automatic when policy is enabled and validation URL is present (no separate toggle required) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Restore the hierarchical structure where footer enablement controls visibility of QR code and customization options. When user enables 'Add visible footer', both QR code toggle and template customization become available. The footer policy was already implemented server-side; this change restores the user-facing UI toggles for client-side AppConfig persistence while the policy controls the actual runtime behavior. Structure: - Top-level toggle: 'Add visible footer' (policy-driven) - Nested under footer toggle: - QR code toggle (client AppConfig) - Validation URL input (shown when QR enabled) - Template customization toggle - Footer template editor component Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Update test expectations to reflect: 1. Restored hierarchical structure in Validation.vue UI 2. AppConfig mocking restored for FooterTemplateEditor dimension persistence 3. 5 API calls expected (vs 2) for loading all validation settings 4. AppConfig spy assertions for dimension persistence Both test suites pass with updated expectations aligned to restored UI. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Add Workbench integration for the AddFooterPolicy: 1. AddFooterScalarRuleEditor component for boolean selection (Enabled/Disabled) 2. realDefinition in footer/realDefinition.ts with localized labels 3. Register footer setting in realDefinitions.ts catalog Allows admins to configure footer enablement rules through Policy Workbench UI with clear descriptions of enabled vs disabled states and override inheritance behaviors. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Add comprehensive unit tests for AddFooterPolicy:
- Provider builds correct policy definition
- Key is 'add_footer'
- Default system value is true
- Allowed values are [true, false]
- Normalizer handles boolean-like values correctly ('1', '0', 'true',
'false', etc)
Tests verify policy contract compliance and normalization logic.
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Update tests to reflect AddFooterPolicy registration and integration: 1. PolicyServiceTest mocks AddFooterPolicy provider 2. PolicyRegistryTest verifies registry returns AddFooterPolicy definition with correct key and normalization 3. PolicySourceTest includes AddFooterPolicy in policy mocks 4. FooterHandlerTest: - Mocks PolicyService to return AddFooterPolicy resolution - Removed 'write_qrcode_on_footer' AppConfig setup (QR now automatic) - Updated test data providers to match new runtime behavior All tests verify footer policy enablement check and QR code automatic generation when validation URL present. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…el labels Changes: 1. Register addFooterRealDefinition in realDefinitions catalog 2. Fix PolicyRuleEditorPanel switch labels for clarity: - Changed 'Require this signing order' to 'Allow lower-level overrides' - Updated descriptions to reflect override behavior semantics This makes the allow-override toggle language more generic and applicable across different policy types, not just signing order. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…ch tests
Integration and end-to-end test updates:
1. Remove 'config:app:set libresign write_qrcode_on_footer' from Gherkin
setup (QR code no longer has separate toggle in policy system)
2. Update SettingsPolicyWorkbench.spec.ts:
- Add helper function findConfigureButtonForSetting() for more
reliable button location in test
- Use helper to find Configure buttons for specific settings by title
- Improves test stability by avoiding brittle button selection
QR code behavior is now automatic when footer enabled and validation URL
present.
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…ation url Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…finition Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…nfig Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…lues Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…setting Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…payload Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
… payload Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.