Modernize encryption and signature support; post-quantum signatures, SHA-3 digests.#1549
Open
andreasrosdalw wants to merge 4 commits intoLibrePDF:masterfrom
Open
Modernize encryption and signature support; post-quantum signatures, SHA-3 digests.#1549andreasrosdalw wants to merge 4 commits intoLibrePDF:masterfrom
andreasrosdalw wants to merge 4 commits intoLibrePDF:masterfrom
Conversation
Encryption & signature modernization - PdfEncryption: document IDs are now generated from SecureRandom (16 bytes) instead of an MD5 hash of time/memory/sequence, removing the last non-spec-mandated MD5 use in the encryption module. - TSAClientBouncyCastle: default TSA imprint digest changed from SHA-1 to SHA-256, and the RFC 3161 nonce is now a 64-bit SecureRandom value instead of System.currentTimeMillis(). - PdfSignatureAppearance: DocMDP DigestMethod changed from MD5 to SHA256 (PDF 2.0 / ISO 32000-2 disallows MD5). - PdfPKCS7: added support for SHA3-256 and SHA3-512 (FIPS 202) as signature digest algorithms, both for creation and verification. - PdfPKCS7: wrapped ASN1InputStream usages in try-with-resources and removed stale "duplicate key" TODO comments that referred to entries in a different map. No public API changes, no new tests.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
…PKCS7 via the Bouncy Castle provider (parameter sets ML-DSA-44, ML-DSA-65, ML-DSA-87). Signing, external-signature, and verification paths recognise the ML-DSA OIDs and JCE algorithm names.
|
andreasrosdalw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the new Feature/Bugfix
Encryption & signature modernization
No public API changes, no new tests.
I spent some "research" and innovation time to try improving and modernizing encryption and signature support using AI copilot.
Your real name
Andreas Røsdal