add Windows and macOS to build matrix, fix cross-platform issues#1547
Draft
sreeya12 wants to merge 3 commits intoLibrePDF:masterfrom
Draft
add Windows and macOS to build matrix, fix cross-platform issues#1547sreeya12 wants to merge 3 commits intoLibrePDF:masterfrom
sreeya12 wants to merge 3 commits intoLibrePDF:masterfrom
Conversation
Added a condition to disable the test on macOS.
Removed unnecessary directory listing in Maven workflow.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR expands CI coverage to include Windows and macOS runners alongside the existing Ubuntu configuration.
Changes:
Added os: [ubuntu-latest, windows-latest, macos-latest] matrix to the Maven build workflow
Removed pwd && ls -l debug step that fails on Windows PowerShell (the ls alias in PowerShell requires different argument syntax)
Added @DisabledOnOs(OS.MAC) annotation to FontTest.testFontStyleOfStyledFont to skip a test that relies on system fonts with specific TrueType OS/2 tables not present on macOS
Motivation:
As part of a research study on OS-specific CI failures in Java/Maven projects (George Mason University, CS 795), we found that OpenPDF's build and test suite is largely portable. Two issues prevented cross-platform CI: a bash-specific ls -l command in the workflow file, and a font test that assumes the presence of specific system fonts (the Courier.ttc font on macOS lacks the OS/2 TrueType table that the test expects).
Verification:
We ran the modified workflow 10 times on each OS. Results:
Ubuntu: 10/10 pass (no regression)
Windows: 10/10 pass (after removing ls -l)
macOS: 10/10 pass (after skipping font-dependent test)