Drop xvfb-run wrapper, no longer needed since LibrePCB 2.2.0#8
Draft
firuzakhmad wants to merge 2 commits into
Draft
Drop xvfb-run wrapper, no longer needed since LibrePCB 2.2.0#8firuzakhmad wants to merge 2 commits into
firuzakhmad wants to merge 2 commits into
Conversation
librepcb-cli now runs headlessly on its own (LibrePCB/LibrePCB#1793), so the xvfb-run wrapper and the xvfb package are no longer needed. Not bumping LIBREPCB_VERSION here since 2.2.0 hasn't been released yet, the build-time version check further down would fail against 2.1.1, which doesn't have the headless fix. Opening as a draft until that's actually available.
Member
|
The wrapper script has no function anymore, so it should be removed completely. Just install the CLI directly to /usr/local. |
The wrapper had no function anymore after dropping xvfb-run, so remove it entirely and just symlink librepcb-cli into /usr/local/bin instead. Keeping the actual install tree at /opt/librepcb rather than extracting straight into /usr/local, since Qt resolves plugin paths relative to that layout.
Author
|
Removed the wrapper script and symlinked librepcb-cli straight into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft on #1793.
Removed the wrapper script and symlinked librepcb-cli directly into
/usr/local/bin, per your suggestion. Kept the actual install under
/opt/librepcb rather than extracting there directly, since Qt looks
for its plugins relative to that path. Also dropped xvfb from the
apt install list, since nothing else needs it.
Confirmed locally that this can't work yet: building against the
current LIBREPCB_VERSION=2.1.1 fails at the "RUN librepcb-cli
--version" sanity check with "error while loading shared libraries:
libGL.so.1: cannot open shared object file", since 2.1.1 has no
fallback logic and tries to initialize the xcb platform without any
display present. Expected, and confirms this needs to wait for a
2.2.0 image.
I'll bump LIBREPCB_VERSION and confirm this actually builds and runs
cleanly once 2.2.0 is out, then mark this ready for review.