Skip to content

Do not report elements of code defined in module types #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fantazio wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Do not report elements of code defined in module types #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fcc249d
[src][deadSign] extract `collect_export`
fantazio Aug 1, 2026
175d0ed
[src][deadSign] add `collect_export_from_typedtree`
fantazio Aug 1, 2026
17f7c21
[src] use cmti signature
fantazio Aug 1, 2026
8245145
[src][deadSign] simplify collect_export_from_typedtree
fantazio Aug 3, 2026
f71a6cd
[src] identify and correct wrong exports
fantazio Aug 3, 2026
934145c
[docs][limitations] merge modtype
fantazio Aug 4, 2026
bff68c6
[src] change `in_modtype` to `implicit_decs`
fantazio Aug 4, 2026
4fc44a7
[docs][limitations] add module type of
fantazio Aug 5, 2026
517055d
[src][deadSign] fix modtype_of FP
fantazio Aug 5, 2026
62b3666
[src][deadSign] refactor
fantazio Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 3 additions & 57 deletions check/classic/classic.ref
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,7 @@
./examples/docs/exported_values/hello_world/hello_world_with_intf.mli:3: goodbye
./examples/docs/exported_values/hello_world/hello_world_with_intf.mli:4: world

./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/with_intf.mli:2: unused: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/with_intf.mli:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/without_intf.ml:2: unused: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/without_intf.mli:4: redefined_unused

./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/with_intf.ml:4: redefined_unused
Expand Down Expand Up @@ -183,34 +181,6 @@ Nothing else to report in this section

.> UNUSED METHODS:
=================
./examples/docs/limitations/modtype/modtype_with_intf.mli:7: Ftor_with.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:7: Incl.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:7: Incl_with.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:7: With.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:8: Ftor_with.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:8: Incl.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:8: Incl_with.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:8: With.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:18: Subst.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:18: Subst.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:29: Incl_subst.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:29: Incl_subst.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:36: Ftor_subst.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:36: Ftor_subst.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:7: Ftor_with.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:7: Incl.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:7: Incl_with.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:7: With.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:8: Ftor_with.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:8: Incl.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:8: Incl_with.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:8: With.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:36: Subst.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:36: Subst.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:74: Incl_subst.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:74: Incl_subst.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:108: Ftor_subst.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:108: Ftor_subst.o#m: Should not be detected
./examples/docs/methods/code_constructs/class/class_bin.ml:2: unused_class#unused_method
./examples/docs/methods/code_constructs/class/class_lib.mli:2: int_stack#reset

Expand Down Expand Up @@ -304,14 +274,6 @@ Nothing else to report in this section
./examples/docs/fields_and_constructors/code_constructs/polymorphic_type/polymorphic_type_lib.mli:2: either.Right
./examples/docs/fields_and_constructors/code_constructs/polymorphic_type/polymorphic_type_lib.mli:3: both.left

./examples/docs/limitations/modtype/modtype_with_intf.mli:4: Ftor_with.ctor.Ctor: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:4: Incl.ctor.Ctor: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:4: Incl_with.ctor.Ctor: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:4: With.ctor.Ctor: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:5: Ftor_with.field.field: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:5: Incl.field.field: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:5: Incl_with.field.field: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:5: With.field.field: Should not be detected
./examples/using_dune/preprocessed_lib/preprocessed.mli:14: constructors.Unused
./examples/using_dune/preprocessed_lib/preprocessed.mli:19: constr_with_eq.Unused
./examples/using_dune/preprocessed_lib/preprocessed.mli:23: record.unused
Expand Down Expand Up @@ -388,14 +350,6 @@ Nothing else to report in this section
=============================
./examples/docs/coding_style/opt/opt.ml:15: ?index

./examples/docs/limitations/modtype/modtype_with_intf.mli:9: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:18: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:29: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:36: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:9: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:36: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:74: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:108: ?always: Should not be detected
./examples/docs/optional_arguments/code_constructs/external_app/external_app_lib.mli:3: ?max

./examples/docs/optional_arguments/code_constructs/hof/hof_bin.ml:2: ?index
Expand Down Expand Up @@ -557,14 +511,6 @@ Nothing else to report in this section

.> OPTIONAL ARGUMENTS: NEVER:
============================
./examples/docs/limitations/modtype/modtype_with_intf.mli:9: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:18: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:29: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:36: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:9: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:36: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:74: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:108: ?never: Should not be detected
./examples/docs/optional_arguments/code_constructs/external_app/external_app_lib.mli:2: ?min

./examples/docs/optional_arguments/code_constructs/internal_app/internal_app_lib.ml:2: ?min
Expand Down Expand Up @@ -781,7 +727,7 @@ Nothing else to report in this section
--------------------------------------------------------------------------------


Total: 653
Total: 599
Success: 595
Failed: 58
Ratio: 91.1179173047%
Failed: 4
Ratio: 99.3322203673%
60 changes: 3 additions & 57 deletions check/internal/internal.ref
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@

./examples/docs/exported_values/code_constructs/module/module_lib.mli:6: M.unused

./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/with_intf.mli:2: unused: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/with_intf.mli:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/without_intf.ml:2: unused: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/without_intf.mli:4: redefined_unused

./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/with_intf.ml:4: redefined_unused
Expand Down Expand Up @@ -135,34 +133,6 @@ Nothing else to report in this section

.> UNUSED METHODS:
=================
./examples/docs/limitations/modtype/modtype_with_intf.mli:7: Ftor_with.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:7: Incl.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:7: Incl_with.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:7: With.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:8: Ftor_with.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:8: Incl.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:8: Incl_with.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:8: With.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:18: Subst.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:18: Subst.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:29: Incl_subst.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:29: Incl_subst.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:36: Ftor_subst.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:36: Ftor_subst.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:7: Ftor_with.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:7: Incl.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:7: Incl_with.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:7: With.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:8: Ftor_with.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:8: Incl.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:8: Incl_with.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:8: With.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:36: Subst.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:36: Subst.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:74: Incl_subst.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:74: Incl_subst.o#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:108: Ftor_subst.c#m: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:108: Ftor_subst.o#m: Should not be detected
./examples/docs/methods/code_constructs/class/class_bin.ml:2: unused_class#unused_method
./examples/docs/methods/code_constructs/class/class_lib.mli:2: int_stack#reset

Expand Down Expand Up @@ -256,14 +226,6 @@ Nothing else to report in this section
./examples/docs/fields_and_constructors/code_constructs/polymorphic_type/polymorphic_type_lib.mli:2: either.Right
./examples/docs/fields_and_constructors/code_constructs/polymorphic_type/polymorphic_type_lib.mli:3: both.left

./examples/docs/limitations/modtype/modtype_with_intf.mli:4: Ftor_with.ctor.Ctor: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:4: Incl.ctor.Ctor: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:4: Incl_with.ctor.Ctor: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:4: With.ctor.Ctor: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:5: Ftor_with.field.field: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:5: Incl.field.field: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:5: Incl_with.field.field: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:5: With.field.field: Should not be detected
./examples/using_dune/preprocessed_lib/preprocessed.mli:14: constructors.Unused
./examples/using_dune/preprocessed_lib/preprocessed.mli:19: constr_with_eq.Unused
./examples/using_dune/preprocessed_lib/preprocessed.mli:23: record.unused
Expand Down Expand Up @@ -340,14 +302,6 @@ Nothing else to report in this section
=============================
./examples/docs/coding_style/opt/opt.ml:15: ?index

./examples/docs/limitations/modtype/modtype_with_intf.mli:9: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:18: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:29: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:36: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:9: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:36: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:74: ?always: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:108: ?always: Should not be detected
./examples/docs/optional_arguments/code_constructs/external_app/external_app_lib.mli:3: ?max

./examples/docs/optional_arguments/code_constructs/hof/hof_bin.ml:2: ?index
Expand Down Expand Up @@ -509,14 +463,6 @@ Nothing else to report in this section

.> OPTIONAL ARGUMENTS: NEVER:
============================
./examples/docs/limitations/modtype/modtype_with_intf.mli:9: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:18: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:29: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_with_intf.mli:36: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:9: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:36: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:74: ?never: Should not be detected
./examples/docs/limitations/modtype/modtype_without_intf.ml:108: ?never: Should not be detected
./examples/docs/optional_arguments/code_constructs/external_app/external_app_lib.mli:2: ?min

./examples/docs/optional_arguments/code_constructs/internal_app/internal_app_lib.ml:2: ?min
Expand Down Expand Up @@ -733,7 +679,7 @@ Nothing else to report in this section
--------------------------------------------------------------------------------


Total: 609
Total: 555
Success: 551
Failed: 58
Ratio: 90.4761904762%
Failed: 4
Ratio: 99.2792792793%
Loading
Loading