fix(purchase): surface save error on failed-status execution record

[cristim]

Problem

COR-10 (#1184): in executeForAccount (internal/purchase/execution.go), the credential-resolution failure branch discarded the SavePurchaseExecution error (_ =), while the post-purchase save thirty lines later treats a save failure as AUDIT LOSS and returns it. If the DB write failed on the credential-failure path, the per-account "failed" row was silently lost with no log and no error, leaving a gap in the History audit trail.

Fix

Handle the failure-path save exactly like the success path: when the save fails, return an AUDIT LOSS: failed to save execution record ... error joined (via errors.Join) with the original credential-resolution error, so neither failure is masked and the underlying save error stays inspectable via errors.Is.

Test evidence

• New regression test TestExecuteForAccount_CredentialFailure_SaveErrorSurfaced replicates the real scenario (credential resolution fails AND the failed-row save fails) and asserts both the AUDIT LOSS error and the credential error surface.
• Confirmed it FAILS on pre-fix code (save error silently dropped) and passes with the fix.
• go build ./... clean; go test ./internal/purchase/... -count=1: 207 passed; go vet clean.
• Per the finding guidance, execution_test.go timing assertions were not touched (TEST-05 / TEST-05: Elapsed-wall-time parallelism assertion in purchase fan-out test is CI-load sensitive #1158 is separate).

Closes #1184

[coderabbitai]

Warning

Review limit reached

@cristim, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 6 minutes and 58 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d49a9e28-7471-48a9-9e6a-e3299dda8aba

📥 Commits

Reviewing files that changed from the base of the PR and between 451a70f and 4b68325.

📒 Files selected for processing (2)

• internal/purchase/execution.go
• internal/purchase/execution_test.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/cor-10-fix

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cristim]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[cristim]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.