Fixed issue with borders around indeterminate progress bars.#6
Open
zoltan-dulac wants to merge 2 commits intoLeaVerou:masterfrom
Open
Fixed issue with borders around indeterminate progress bars.#6zoltan-dulac wants to merge 2 commits intoLeaVerou:masterfrom
zoltan-dulac wants to merge 2 commits intoLeaVerou:masterfrom
Conversation
added 2 commits
January 3, 2012 17:18
…rogress bar. If the value of the progress bar is set to zero, the progress bar increases in width slightly, until the value is changed to a non-zero value. Fixed by changing offsetWidth to clientWidth.
Owner
|
Wow, sorry for the delay! Why removed minified version? It would be a nice addition. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small bug appears when a border is applied to the progress bar. If the value of the progress bar is set to zero, the progress bar increases in width slightly, until the value is changed to a non-zero value.
NOTE that I didn't change progress-polyfill.min.js, since I wasn't sure what you used to minify it (I used Google Closure, and it was very different, so I thought I'd ask first).
You can see what I mean here:
http://www.useragentman.com/tmp/progressPolyfill/test1.html
In order to fix this issue, I changed line 161 from:
if(progress.position !== -1) {
progress.style.paddingRight = progress.offsetWidth *
(1-progress.position) + 'px';
}
to this:
if(progress.position !== -1) {
progress.style.paddingRight = progress.clientWidth *
(1-progress.position) + 'px';
}
(Note the change from offsetWidth to clientWidth). When this is
applied, the jump in width doesn't happen anymore, as seen here:
http://www.useragentman.com/tmp/progressPolyfill/test1-fixed.html